Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: tools/telemetry/telemetry/value/failure_unittest.py

Issue 417193005: Add Value FromDict to Telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/failure.py ('k') | tools/telemetry/telemetry/value/histogram.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/failure_unittest.py
diff --git a/tools/telemetry/telemetry/value/failure_unittest.py b/tools/telemetry/telemetry/value/failure_unittest.py
index 799e047f691517c7f944ea34f8067fd8cf65b41f..fbcd7564f313a43b0a27d8f1e404497ada1104a8 100644
--- a/tools/telemetry/telemetry/value/failure_unittest.py
+++ b/tools/telemetry/telemetry/value/failure_unittest.py
@@ -5,6 +5,7 @@
import os
import sys
import unittest
+import traceback
from telemetry import value
from telemetry.page import page_set
@@ -22,12 +23,12 @@ class TestBase(unittest.TestCase):
class ValueTest(TestBase):
def testName(self):
v0 = failure.FailureValue.FromMessage(self.pages[0], 'Failure')
- self.assertEqual('Exception', v0.name)
+ self.assertEquals('Exception', v0.name)
try:
raise NotImplementedError()
except Exception:
v1 = failure.FailureValue(self.pages[0], sys.exc_info())
- self.assertEqual('NotImplementedError', v1.name)
+ self.assertEquals('NotImplementedError', v1.name)
def testBuildbotAndRepresentativeValue(self):
v = failure.FailureValue.FromMessage(self.pages[0], 'Failure')
@@ -42,3 +43,19 @@ class ValueTest(TestBase):
v = failure.FailureValue.FromMessage(self.pages[0], 'Failure')
d = v.AsDictWithoutBaseClassEntries()
self.assertTrue(d['value'].find('Exception: Failure') > -1)
+
+ def testFromDict(self):
+ try:
+ raise Exception('test')
+ except Exception:
+ exc_info = sys.exc_info()
+ d = {
+ 'type': 'failure',
+ 'name': exc_info[0].__name__,
+ 'units': '',
+ 'value': ''.join(traceback.format_exception(*exc_info))
+ }
+ v = value.Value.FromDict(d, {})
+
+ self.assertTrue(isinstance(v, failure.FailureValue))
+ self.assertEquals(v.name, 'Exception')
« no previous file with comments | « tools/telemetry/telemetry/value/failure.py ('k') | tools/telemetry/telemetry/value/histogram.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698