Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: tools/telemetry/telemetry/value/skip_unittest.py

Issue 417193005: Add Value FromDict to Telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/skip.py ('k') | tools/telemetry/telemetry/value/string.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/skip_unittest.py
diff --git a/tools/telemetry/telemetry/value/skip_unittest.py b/tools/telemetry/telemetry/value/skip_unittest.py
index beab6244aed9221a3bbcb24112e96aa081caf630..8e7b01df2592e1028f479b7896c9e42b65c90765 100644
--- a/tools/telemetry/telemetry/value/skip_unittest.py
+++ b/tools/telemetry/telemetry/value/skip_unittest.py
@@ -32,3 +32,14 @@ class ValueTest(TestBase):
v = skip.SkipValue(self.pages[0], 'page skipped for testing reason')
d = v.AsDictWithoutBaseClassEntries()
self.assertEquals(d['reason'], 'page skipped for testing reason')
+
+ def testFromDict(self):
+ d = {
+ 'type': 'skip',
+ 'name': 'skip',
+ 'units': '',
+ 'reason': 'page skipped for testing reason'
+ }
+ v = value.Value.FromDict(d, {})
+ self.assertTrue(isinstance(v, skip.SkipValue))
+ self.assertEquals(v.reason, 'page skipped for testing reason')
« no previous file with comments | « tools/telemetry/telemetry/value/skip.py ('k') | tools/telemetry/telemetry/value/string.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698