Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: tools/telemetry/telemetry/value/histogram_unittest.py

Issue 417193005: Add Value FromDict to Telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/histogram_unittest.py
diff --git a/tools/telemetry/telemetry/value/histogram_unittest.py b/tools/telemetry/telemetry/value/histogram_unittest.py
index adeb16b6b2e4adad60bf3c32b53686c0109c4917..1f8454a15c59270b1d949b332d6d32ddab682296 100644
--- a/tools/telemetry/telemetry/value/histogram_unittest.py
+++ b/tools/telemetry/telemetry/value/histogram_unittest.py
@@ -53,7 +53,7 @@ class ValueTest(TestBase):
'count': 78
})
- def testAsDictIsAccurate(self):
+ def testAsDict(self):
histogram = histogram_module.HistogramValue(
None, 'x', 'counts',
raw_value_json='{"buckets": [{"low": 1, "high": 2, "count": 1}]}',
@@ -63,3 +63,17 @@ class ValueTest(TestBase):
self.assertEquals(['buckets'], d.keys())
self.assertTrue(isinstance(d['buckets'], list))
self.assertEquals(len(d['buckets']), 1)
+
+ def testFromDict(self):
+ d = {
+ 'type': 'histogram',
+ 'name': 'x',
+ 'units': 'counts',
+ 'buckets': [{'low': 1, 'high': 2, 'count': 1}]
+ }
+ v = value.Value.FromDict(d, {})
+
+ self.assertTrue(isinstance(v, histogram_module.HistogramValue))
+ self.assertEquals(
+ ['{"buckets": [{"low": 1, "high": 2, "count": 1}]}'],
+ v.GetBuildbotValue())
« no previous file with comments | « tools/telemetry/telemetry/value/histogram.py ('k') | tools/telemetry/telemetry/value/list_of_scalar_values.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698