Index: tools/telemetry/telemetry/value/skip.py |
diff --git a/tools/telemetry/telemetry/value/skip.py b/tools/telemetry/telemetry/value/skip.py |
index 11eb3bc5cb6001a359a76d24177f0ae374bf3f30..997ae2b13b4fbbabc73a5e4fec07def2a31f6dbf 100644 |
--- a/tools/telemetry/telemetry/value/skip.py |
+++ b/tools/telemetry/telemetry/value/skip.py |
@@ -39,8 +39,8 @@ class SkipValue(value_module.Value): |
def GetRepresentativeString(self): |
return None |
- @classmethod |
- def GetJSONTypeName(cls): |
+ @staticmethod |
+ def GetJSONTypeName(): |
return 'skip' |
def AsDict(self): |
@@ -48,6 +48,18 @@ class SkipValue(value_module.Value): |
d['reason'] = self._reason |
return d |
+ @staticmethod |
+ def FromDict(value_dict, page_dict): |
+ kwargs = value_module.Value.GetConstructorKwArgs(value_dict, page_dict) |
+ del kwargs['name'] |
+ del kwargs['units'] |
+ important = kwargs.get('important', None) |
+ if important != None: |
+ del kwargs['important'] |
+ kwargs['reason'] = value_dict['reason'] |
+ |
+ return SkipValue(**kwargs) |
+ |
@classmethod |
def MergeLikeValuesFromSamePage(cls, values): |
assert False, 'Should not be called.' |