Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: tools/telemetry/telemetry/value/skip.py

Issue 417193005: Add Value FromDict to Telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/skip.py
diff --git a/tools/telemetry/telemetry/value/skip.py b/tools/telemetry/telemetry/value/skip.py
index 11eb3bc5cb6001a359a76d24177f0ae374bf3f30..997ae2b13b4fbbabc73a5e4fec07def2a31f6dbf 100644
--- a/tools/telemetry/telemetry/value/skip.py
+++ b/tools/telemetry/telemetry/value/skip.py
@@ -39,8 +39,8 @@ class SkipValue(value_module.Value):
def GetRepresentativeString(self):
return None
- @classmethod
- def GetJSONTypeName(cls):
+ @staticmethod
+ def GetJSONTypeName():
return 'skip'
def AsDict(self):
@@ -48,6 +48,18 @@ class SkipValue(value_module.Value):
d['reason'] = self._reason
return d
+ @staticmethod
+ def FromDict(value_dict, page_dict):
+ kwargs = value_module.Value.GetConstructorKwArgs(value_dict, page_dict)
+ del kwargs['name']
+ del kwargs['units']
+ important = kwargs.get('important', None)
+ if important != None:
+ del kwargs['important']
+ kwargs['reason'] = value_dict['reason']
+
+ return SkipValue(**kwargs)
+
@classmethod
def MergeLikeValuesFromSamePage(cls, values):
assert False, 'Should not be called.'
« no previous file with comments | « tools/telemetry/telemetry/value/scalar_unittest.py ('k') | tools/telemetry/telemetry/value/skip_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698