Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: tools/telemetry/telemetry/value/list_of_string_values.py

Issue 417193005: Add Value FromDict to Telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/list_of_string_values.py
diff --git a/tools/telemetry/telemetry/value/list_of_string_values.py b/tools/telemetry/telemetry/value/list_of_string_values.py
index 9e8566a80c2c5cf4c778afef7da30bf839e6e3a3..b8a35b626da9d74807aa1bdee831eae5352c2f3b 100644
--- a/tools/telemetry/telemetry/value/list_of_string_values.py
+++ b/tools/telemetry/telemetry/value/list_of_string_values.py
@@ -54,8 +54,8 @@ class ListOfStringValues(value_module.Value):
return (super(ListOfStringValues, self).IsMergableWith(that) and
self.same_page_merge_policy == that.same_page_merge_policy)
- @classmethod
- def GetJSONTypeName(cls):
+ @staticmethod
+ def GetJSONTypeName():
return 'list_of_string_values'
def AsDict(self):
@@ -63,6 +63,13 @@ class ListOfStringValues(value_module.Value):
d['values'] = self.values
return d
+ @staticmethod
+ def FromDict(value_dict, page_dict):
+ kwargs = value_module.Value.GetConstructorKwArgs(value_dict, page_dict)
+ kwargs['values'] = value_dict['values']
+
+ return ListOfStringValues(**kwargs)
+
@classmethod
def MergeLikeValuesFromSamePage(cls, values):
assert len(values) > 0

Powered by Google App Engine
This is Rietveld 408576698