Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: tools/telemetry/telemetry/value/list_of_string_values_unittest.py

Issue 417193005: Add Value FromDict to Telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/list_of_string_values.py ('k') | tools/telemetry/telemetry/value/scalar.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/list_of_string_values_unittest.py
diff --git a/tools/telemetry/telemetry/value/list_of_string_values_unittest.py b/tools/telemetry/telemetry/value/list_of_string_values_unittest.py
index 42d26f0d70d8d391adfc1ae681d46df7f1864a84..594ecd683e88ee9af965f2786f5a6212b7bf1ba0 100644
--- a/tools/telemetry/telemetry/value/list_of_string_values_unittest.py
+++ b/tools/telemetry/telemetry/value/list_of_string_values_unittest.py
@@ -77,7 +77,7 @@ class ListOfStringValuesTest(TestBase):
self.assertEquals(True, vM.important)
self.assertEquals(['L1', 'L2', 'L3', 'L4'], vM.values)
- def testAsDictIsAccurate(self):
+ def testAsDict(self):
v = list_of_string_values.ListOfStringValues(
None, 'x', 'unit', ['foo', 'bar'],
same_page_merge_policy=value.PICK_FIRST, important=False)
@@ -86,3 +86,15 @@ class ListOfStringValuesTest(TestBase):
self.assertEquals(d, {
'values': ['foo', 'bar']
})
+
+ def testFromDict(self):
+ d = {
+ 'type': 'list_of_string_values',
+ 'name': 'x',
+ 'units': 'unit',
+ 'values': ['foo', 'bar']
+ }
+ v = value.Value.FromDict(d, {})
+
+ self.assertTrue(isinstance(v, list_of_string_values.ListOfStringValues))
+ self.assertEquals(v.values, ['foo', 'bar'])
« no previous file with comments | « tools/telemetry/telemetry/value/list_of_string_values.py ('k') | tools/telemetry/telemetry/value/scalar.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698