Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: tools/telemetry/telemetry/value/string.py

Issue 417193005: Add Value FromDict to Telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/string.py
diff --git a/tools/telemetry/telemetry/value/string.py b/tools/telemetry/telemetry/value/string.py
index a62832218edb017bf5ca7860707c41ea43233b8f..a36625d406e6a37234352464d1dca1ae8fa41e93 100644
--- a/tools/telemetry/telemetry/value/string.py
+++ b/tools/telemetry/telemetry/value/string.py
@@ -47,8 +47,8 @@ class StringValue(value_module.Value):
def GetRepresentativeString(self):
return str(self.value)
- @classmethod
- def GetJSONTypeName(cls):
+ @staticmethod
+ def GetJSONTypeName():
return 'string'
def AsDict(self):
@@ -56,6 +56,13 @@ class StringValue(value_module.Value):
d['value'] = self.value
return d
+ @staticmethod
+ def FromDict(value_dict, page_dict):
+ kwargs = value_module.Value.GetConstructorKwArgs(value_dict, page_dict)
+ kwargs['value'] = value_dict['value']
+
+ return StringValue(**kwargs)
+
@classmethod
def MergeLikeValuesFromSamePage(cls, values):
assert len(values) > 0
« no previous file with comments | « tools/telemetry/telemetry/value/skip_unittest.py ('k') | tools/telemetry/telemetry/value/string_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698