Use content::RunBlockingPoolTask() in tests.

Use content::RunBlockingPoolTask() in tests.

The new utility function should be used instead of manually flushing the
blocking pool.

This CL replaces BlockingPool::FlushForTesting and RunLoop::RunUntilIdle()
wherever it was obvious. Along the way lint errors have been fixed.

TEST=Refactoring only. All current tests should pass.
BUG=392716
Committed: https://crrev.com/f7d99a5c7cf7d2286061cc7edc87a1f5451f880c
Cr-Commit-Position: refs/heads/master@{#294835}

[mtomasz, 2014-07-23 06:13:31]

@darin, @sky: PTAL. Thanks.

[mtomasz, 2014-09-01 04:41:37]

On 2014/07/23 06:13:31, mtomasz wrote:
> @darin, @sky: PTAL. Thanks.

@darin, @sky: Ping.

[mtomasz, 2014-09-08 00:18:35]

On 2014/09/01 04:41:37, mtomasz wrote:
> On 2014/07/23 06:13:31, mtomasz wrote:
> > @darin, @sky: PTAL. Thanks.
> 
> @darin, @sky: Ping.

@darin, @sky: Friendly ping. If you're busy please let me know, then I'll find
other reviewers. Thanks.

[sky, 2014-09-08 15:51:37]

https://codereview.chromium.org/409743003/diff/160001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/supervised/supervised_user_test_base.h
(right):

https://codereview.chromium.org/409743003/diff/160001/chrome/browser/chromeos...
chrome/browser/chromeos/login/supervised/supervised_user_test_base.h:95: void
RemoveSupervisedUser(uint32 original_user_count,
Why this change? And if you're going to change this you should be using
uint32_t.

[Lei Zhang, 2014-09-08 18:21:02]

https://codereview.chromium.org/409743003/diff/160001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/supervised/supervised_user_test_base.h
(right):

https://codereview.chromium.org/409743003/diff/160001/chrome/browser/chromeos...
chrome/browser/chromeos/login/supervised/supervised_user_test_base.h:95: void
RemoveSupervisedUser(uint32 original_user_count,
On 2014/09/08 15:51:37, sky wrote:
> Why this change? And if you're going to change this you should be using
> uint32_t.

re: uint32 vs uint32_t:
https://code.google.com/p/chromium/codesearch#chromium/src/base/basictypes.h&...

[mtomasz, 2014-09-09 01:15:32]

https://codereview.chromium.org/409743003/diff/160001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/supervised/supervised_user_test_base.h
(right):

https://codereview.chromium.org/409743003/diff/160001/chrome/browser/chromeos...
chrome/browser/chromeos/login/supervised/supervised_user_test_base.h:95: void
RemoveSupervisedUser(uint32 original_user_count,
On 2014/09/08 18:21:01, Lei Zhang wrote:
> On 2014/09/08 15:51:37, sky wrote:
> > Why this change? And if you're going to change this you should be using
> > uint32_t.
> 
> re: uint32 vs uint32_t:
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/basictypes.h&...

I did as git cl lint asked:

chrome/browser/chromeos/login/supervised/supervised_user_test_base.h:95:  Use
int16/int64/etc, rather than the C type long  [runtime/int] [4]

Replaced with simple int.

[Lei Zhang, 2014-09-09 01:23:01]

On 2014/09/09 01:15:32, mtomasz wrote:
>
https://codereview.chromium.org/409743003/diff/160001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/supervised/supervised_user_test_base.h
> (right):
> 
>
https://codereview.chromium.org/409743003/diff/160001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/supervised/supervised_user_test_base.h:95: void
> RemoveSupervisedUser(uint32 original_user_count,
> On 2014/09/08 18:21:01, Lei Zhang wrote:
> > On 2014/09/08 15:51:37, sky wrote:
> > > Why this change? And if you're going to change this you should be using
> > > uint32_t.
> > 
> > re: uint32 vs uint32_t:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/basictypes.h&...
> 
> I did as git cl lint asked:
> 
> chrome/browser/chromeos/login/supervised/supervised_user_test_base.h:95:  Use
> int16/int64/etc, rather than the C type long  [runtime/int] [4]
> 
> Replaced with simple int.

Looking at the RemoveSupervisedUser() impl, it probably should just be a size_t.
You should also make sure |original_user_count| > 0.

[mtomasz, 2014-09-10 04:35:24]

On 2014/09/09 01:23:01, Lei Zhang wrote:
> On 2014/09/09 01:15:32, mtomasz wrote:
> >
>
https://codereview.chromium.org/409743003/diff/160001/chrome/browser/chromeos...
> > File chrome/browser/chromeos/login/supervised/supervised_user_test_base.h
> > (right):
> > 
> >
>
https://codereview.chromium.org/409743003/diff/160001/chrome/browser/chromeos...
> > chrome/browser/chromeos/login/supervised/supervised_user_test_base.h:95:
void
> > RemoveSupervisedUser(uint32 original_user_count,
> > On 2014/09/08 18:21:01, Lei Zhang wrote:
> > > On 2014/09/08 15:51:37, sky wrote:
> > > > Why this change? And if you're going to change this you should be using
> > > > uint32_t.
> > > 
> > > re: uint32 vs uint32_t:
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/basictypes.h&...
> > 
> > I did as git cl lint asked:
> > 
> > chrome/browser/chromeos/login/supervised/supervised_user_test_base.h:95: 
Use
> > int16/int64/etc, rather than the C type long  [runtime/int] [4]
> > 
> > Replaced with simple int.
> 
> Looking at the RemoveSupervisedUser() impl, it probably should just be a
size_t.
> You should also make sure |original_user_count| > 0.

Done. PTAL.

[sky, 2014-09-10 14:44:29]

LGTM

[mtomasz, 2014-09-11 05:11:49]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-09-11 05:12:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/409743003/220001

[commit-bot: I haz the power, 2014-09-11 05:22:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 05:22:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mtomasz, 2014-09-11 05:27:47]

mtomasz@chromium.org changed reviewers:
+ jvoung@chromium.org
- darin@chromium.org

[mtomasz, 2014-09-11 05:28:05]

@jvoung: PTAL at components/nacl/browser/pnacl_host_unittest.cc. Thanks.

[jvoung (off chromium), 2014-09-11 15:56:41]

lgtm

[mtomasz, 2014-09-11 23:15:34]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-09-11 23:22:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/409743003/220001

[commit-bot: I haz the power, 2014-09-12 00:35:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 00:35:24]

Failed to commit the patch.

[mtomasz, 2014-09-15 16:21:47]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-09-15 16:22:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/409743003/220001

[commit-bot: I haz the power, 2014-09-15 16:27:52]

Committed patchset #12 (id:220001) as 019568436b226539dc8c01b2b0c64337b70aa710

[commit-bot: I haz the power, 2014-09-15 16:31:21]

Patchset 12 (id:??) landed as
https://crrev.com/f7d99a5c7cf7d2286061cc7edc87a1f5451f880c
Cr-Commit-Position: refs/heads/master@{#294835}

[Lei Zhang, 2014-09-19 21:10:13]

https://codereview.chromium.org/409743003/diff/220001/chrome/browser/extensio...
File chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
(right):

https://codereview.chromium.org/409743003/diff/220001/chrome/browser/extensio...
chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc:10:
#include "base/file_util.h"
Please be aware that this is going away. Use base/files/file_util.h in the
future. I had removed all references, but they keep sneaking back in.