chrome/browser/geolocation/geolocation_permission_context_unittest.cc - Issue 409743003: Use content::RunBlockingPoolTask() in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Issue 409743003: Use content::RunBlockingPoolTask() in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc ('K') | « chrome/browser/extensions/requirements_checker_browsertest.cc ('k') | chrome/browser/media_galleries/media_folder_finder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

index 9ae3a305414dee56dd96abfacef9508e28c93f37..ee63eca462e1d2279bb5b3e4d59d6a47ee39e567 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

@@ -10,8 +10,8 @@

#include "base/bind.h"

#include "base/containers/hash_tables.h"

+#include "base/id_map.h"

#include "base/memory/scoped_vector.h"

-#include "base/run_loop.h"

#include "base/synchronization/waitable_event.h"

#include "base/test/simple_test_clock.h"

#include "base/time/clock.h"

@@ -32,6 +32,7 @@

#include "content/public/browser/web_contents.h"

#include "content/public/test/mock_render_process_host.h"

#include "content/public/test/test_renderer_host.h"

+#include "content/public/test/test_utils.h"

#include "content/public/test/web_contents_tester.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -179,8 +180,7 @@ void GeolocationPermissionContextTests::RequestGeolocationPermission(

base::Bind(&GeolocationPermissionContextTests::PermissionResponse,

base::Unretained(this), id),

cancel_callback);

- content::BrowserThread::GetBlockingPool()->FlushForTesting();

- base::RunLoop().RunUntilIdle();

+ content::RunAllBlockingPoolTasksUntilIdle();

}

void GeolocationPermissionContextTests::PermissionResponse(