chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc - Issue 409743003: Use content::RunBlockingPoolTask() in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc

Issue 409743003: Use content::RunBlockingPoolTask() in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc ('K') | « chrome/browser/sessions/session_service_test_helper.cc ('k') | chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc

diff --git a/chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc b/chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc

index 2e26842de52959c2141a31caad1da5fc01314039..a3b81f4cff9b71a936017eba3c21fc16accf19f4 100644

--- a/chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc

+++ b/chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc

@@ -2,6 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "chrome/browser/supervised_user/supervised_user_registration_utility.h"

#include "base/bind.h"

#include "base/message_loop/message_loop.h"

#include "base/prefs/scoped_user_pref_update.h"

@@ -9,7 +11,6 @@

#include "base/strings/utf_string_conversions.h"

#include "base/threading/sequenced_worker_pool.h"

#include "chrome/browser/supervised_user/supervised_user_refresh_token_fetcher.h"

-#include "chrome/browser/supervised_user/supervised_user_registration_utility.h"

#include "chrome/browser/supervised_user/supervised_user_shared_settings_service.h"

#include "chrome/browser/supervised_user/supervised_user_shared_settings_service_factory.h"

#include "chrome/browser/supervised_user/supervised_user_sync_service.h"

@@ -18,6 +19,7 @@

#include "chrome/test/base/testing_pref_service_syncable.h"

#include "chrome/test/base/testing_profile.h"

#include "content/public/browser/browser_thread.h"

+#include "content/public/test/test_utils.h"

#include "google_apis/gaia/google_service_auth_error.h"

#include "sync/api/attachments/attachment_id.h"

#include "sync/api/sync_change.h"

@@ -163,8 +165,7 @@ SupervisedUserRegistrationUtilityTest::

}

void SupervisedUserRegistrationUtilityTest::TearDown() {

- content::BrowserThread::GetBlockingPool()->FlushForTesting();

- base::RunLoop().RunUntilIdle();

+ content::RunAllBlockingPoolTasksUntilIdle();

}

scoped_ptr<SyncChangeProcessor>