Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/browser/media_galleries/media_folder_finder_unittest.cc

Issue 409743003: Use content::RunBlockingPoolTask() in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media_galleries/media_folder_finder.h" 5 #include "chrome/browser/media_galleries/media_folder_finder.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 9
10 #include "base/base_paths.h" 10 #include "base/base_paths.h"
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/files/file_util.h" 12 #include "base/files/file_util.h"
13 #include "base/files/scoped_temp_dir.h" 13 #include "base/files/scoped_temp_dir.h"
14 #include "base/run_loop.h"
15 #include "base/strings/stringprintf.h" 14 #include "base/strings/stringprintf.h"
16 #include "base/test/scoped_path_override.h" 15 #include "base/test/scoped_path_override.h"
17 #include "base/threading/sequenced_worker_pool.h" 16 #include "base/threading/sequenced_worker_pool.h"
18 #include "chrome/browser/media_galleries/media_scan_types.h" 17 #include "chrome/browser/media_galleries/media_scan_types.h"
19 #include "chrome/common/chrome_paths.h" 18 #include "chrome/common/chrome_paths.h"
20 #include "content/public/browser/browser_thread.h" 19 #include "content/public/browser/browser_thread.h"
21 #include "content/public/test/test_browser_thread_bundle.h" 20 #include "content/public/test/test_browser_thread_bundle.h"
22 21 #include "content/public/test/test_utils.h"
23 22
24 class MediaFolderFinderTest : public testing::Test { 23 class MediaFolderFinderTest : public testing::Test {
25 public: 24 public:
26 MediaFolderFinderTest() { 25 MediaFolderFinderTest() {
27 } 26 }
28 27
29 virtual ~MediaFolderFinderTest() { 28 virtual ~MediaFolderFinderTest() {
30 } 29 }
31 30
32 virtual void SetUp() OVERRIDE { 31 virtual void SetUp() OVERRIDE {
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 std::string dummy_data; 128 std::string dummy_data;
130 dummy_data.resize(filesize); 129 dummy_data.resize(filesize);
131 130
132 int bytes_written = 131 int bytes_written =
133 base::WriteFile(test_file, dummy_data.c_str(), filesize); 132 base::WriteFile(test_file, dummy_data.c_str(), filesize);
134 ASSERT_GE(bytes_written, 0); 133 ASSERT_GE(bytes_written, 0);
135 ASSERT_EQ(filesize, static_cast<size_t>(bytes_written)); 134 ASSERT_EQ(filesize, static_cast<size_t>(bytes_written));
136 } 135 }
137 } 136 }
138 137
139 void RunLoop() {
140 base::RunLoop().RunUntilIdle();
141 content::BrowserThread::GetBlockingPool()->FlushForTesting();
142 }
143
144 void RunLoopUntilReceivedCallback() { 138 void RunLoopUntilReceivedCallback() {
145 while (!received_results()) 139 while (!received_results())
146 RunLoop(); 140 content::RunAllBlockingPoolTasksUntilIdle();
147 } 141 }
148 142
149 private: 143 private:
150 void OnGotResults( 144 void OnGotResults(
151 bool success, 145 bool success,
152 const MediaFolderFinder::MediaFolderFinderResults& results) { 146 const MediaFolderFinder::MediaFolderFinderResults& results) {
153 received_results_ = true; 147 received_results_ = true;
154 EXPECT_EQ(expected_success_, success); 148 EXPECT_EQ(expected_success_, success);
155 std::set<base::FilePath> expected_keys = 149 std::set<base::FilePath> expected_keys =
156 GetKeysFromResults(expected_results_); 150 GetKeysFromResults(expected_results_);
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 EXPECT_TRUE(received_results()); 197 EXPECT_TRUE(received_results());
204 } 198 }
205 199
206 TEST_F(MediaFolderFinderTest, ScanAndCancel) { 200 TEST_F(MediaFolderFinderTest, ScanAndCancel) {
207 MediaFolderFinder::MediaFolderFinderResults expected_results; 201 MediaFolderFinder::MediaFolderFinderResults expected_results;
208 std::vector<base::FilePath> folders; 202 std::vector<base::FilePath> folders;
209 folders.push_back(fake_dir()); 203 folders.push_back(fake_dir());
210 CreateMediaFolderFinder(folders, false, expected_results); 204 CreateMediaFolderFinder(folders, false, expected_results);
211 StartScan(); 205 StartScan();
212 DeleteMediaFolderFinder(); 206 DeleteMediaFolderFinder();
213 RunLoop(); 207 content::RunAllBlockingPoolTasksUntilIdle();
214 EXPECT_TRUE(received_results()); 208 EXPECT_TRUE(received_results());
215 } 209 }
216 210
217 TEST_F(MediaFolderFinderTest, ScanNothing) { 211 TEST_F(MediaFolderFinderTest, ScanNothing) {
218 MediaFolderFinder::MediaFolderFinderResults expected_results; 212 MediaFolderFinder::MediaFolderFinderResults expected_results;
219 std::vector<base::FilePath> folders; 213 std::vector<base::FilePath> folders;
220 CreateMediaFolderFinder(folders, true, expected_results); 214 CreateMediaFolderFinder(folders, true, expected_results);
221 StartScan(); 215 StartScan();
222 RunLoopUntilReceivedCallback(); 216 RunLoopUntilReceivedCallback();
223 DeleteMediaFolderFinder(); 217 DeleteMediaFolderFinder();
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 396
403 // |fake_home_dir| and its ancestors do not show up in results. 397 // |fake_home_dir| and its ancestors do not show up in results.
404 expected_results.erase(fake_dir()); 398 expected_results.erase(fake_dir());
405 expected_results.erase(fake_home_dir); 399 expected_results.erase(fake_home_dir);
406 400
407 CreateMediaFolderFinder(folders, true, expected_results); 401 CreateMediaFolderFinder(folders, true, expected_results);
408 StartScan(); 402 StartScan();
409 RunLoopUntilReceivedCallback(); 403 RunLoopUntilReceivedCallback();
410 DeleteMediaFolderFinder(); 404 DeleteMediaFolderFinder();
411 } 405 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698