chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm - Issue 409743003: Use content::RunBlockingPoolTask() in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

Issue 409743003: Use content::RunBlockingPoolTask() in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc ('K') | « chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc ('k') | chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

index 2993e8a33877484d7c1dd4152b0edbd1e6b68e5e..8c9ac58731f89e670f7b306d5deffca52608ed24 100644

--- a/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

@@ -11,6 +11,7 @@

#import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"

#include "chrome/test/base/in_process_browser_test.h"

#include "content/public/browser/browser_thread.h"

+#include "content/public/test/test_utils.h"

#include "extensions/common/extension.h"

namespace {

@@ -48,8 +49,7 @@ IN_PROC_BROWSER_TEST_F(WindowedInstallDialogControllerBrowserTest,

base::Bind(&TestingShowAppListInstallDialogController, &controller));

// The prompt needs to load the image, which happens on the blocking pool.

- content::BrowserThread::GetBlockingPool()->FlushForTesting();

- base::RunLoop().RunUntilIdle();

+ content::RunAllBlockingPoolTasksUntilIdle();

ASSERT_TRUE(controller);

base::scoped_nsobject<NSWindow> window(