chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc - Issue 409743003: Use content::RunBlockingPoolTask() in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc

Issue 409743003: Use content::RunBlockingPoolTask() in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/wizard_controller_browsertest.cc ('k') | chrome/browser/chromeos/settings/device_settings_test_helper.h » ('j') | chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc

diff --git a/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc b/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc

index ebf92d67fd648c3bb8e6bf81b40bc1d21efdf70d..acd1b98f3edc55d6ab5b9ea2db0dc906ebfae891 100644

--- a/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc

+++ b/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.h"

+#include <string>

#include <vector>

#include "base/basictypes.h"

@@ -19,6 +20,7 @@

#include "chromeos/cryptohome/cryptohome_util.h"

#include "chromeos/dbus/dbus_thread_manager.h"

#include "chromeos/dbus/fake_cryptohome_client.h"

+#include "content/public/test/test_utils.h"

#include "policy/policy_constants.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -183,7 +185,7 @@ TEST_F(DeviceCloudPolicyStoreChromeOSTest, StoreKeyRotation) {

device_policy_.SetDefaultNewSigningKey();

device_policy_.Build();

store_->Store(device_policy_.policy());

- device_settings_test_helper_.FlushLoops();

+ content::RunAllBlockingPoolTasksUntilIdle();

device_settings_test_helper_.FlushStore();

owner_key_util_->SetPublicKeyFromPrivateKey(

*device_policy_.GetNewSigningKey());