chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc - Issue 409743003: Use content::RunBlockingPoolTask() in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc

Issue 409743003: Use content::RunBlockingPoolTask() in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc ('k') | chrome/browser/chromeos/login/supervised/supervised_user_test_base.h » ('j') | chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc

diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc b/chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc

index a9c30cafa714585dc01e4f66da242c8a7ee429a7..e3a0ddb6e3ebb881fd49cc001d009b4927c02ce9 100644

--- a/chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc

+++ b/chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc

@@ -2,6 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "chrome/browser/chromeos/app_mode/kiosk_app_update_service.h"

#include <string>

#include "base/basictypes.h"

@@ -20,7 +22,6 @@

#include "chrome/browser/apps/app_browsertest_util.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/browser_process_platform_part.h"

-#include "chrome/browser/chromeos/app_mode/kiosk_app_update_service.h"

#include "chrome/browser/chromeos/system/automatic_reboot_manager.h"

#include "chrome/browser/extensions/extension_test_message_listener.h"

#include "chrome/browser/profiles/profile.h"

@@ -68,8 +69,7 @@ class KioskAppUpdateServiceTest : public extensions::PlatformAppBrowserTest {

update_service_ = KioskAppUpdateServiceFactory::GetForProfile(profile());

update_service_->set_app_id(app_->id());

- content::BrowserThread::GetBlockingPool()->FlushForTesting();

- content::RunAllPendingInMessageLoop();

+ content::RunAllBlockingPoolTasksUntilIdle();

}

void FireAppUpdateAvailable() {