Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: components/visitedlink/test/visitedlink_unittest.cc

Issue 409743003: Use content::RunBlockingPoolTask() in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/visitedlink/test/visitedlink_unittest.cc
diff --git a/components/visitedlink/test/visitedlink_unittest.cc b/components/visitedlink/test/visitedlink_unittest.cc
index 63643187d067092540c6c65010218fdfd1f2dd4c..88b068dcca860adaf51d0dc5598a2832f04e37f8 100644
--- a/components/visitedlink/test/visitedlink_unittest.cc
+++ b/components/visitedlink/test/visitedlink_unittest.cc
@@ -26,6 +26,7 @@
#include "content/public/test/test_browser_context.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/test_renderer_host.h"
+#include "content/public/test/test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
@@ -59,7 +60,6 @@ class TestVisitedLinkDelegate : public VisitedLinkDelegate {
void AddURLForRebuild(const GURL& url);
private:
-
URLs rebuild_urls_;
};
@@ -159,7 +159,7 @@ class VisitedLinkTest : public testing::Test {
master_.reset(NULL);
// Wait for all pending file I/O to be completed.
- BrowserThread::GetBlockingPool()->FlushForTesting();
+ content::RunAllBlockingPoolTasksUntilIdle();
}
// Loads the database from disk and makes sure that the same URLs are present
@@ -585,7 +585,6 @@ class VisitedLinkRenderProcessHostFactory
}
private:
-
DISALLOW_COPY_AND_ASSIGN(VisitedLinkRenderProcessHostFactory);
};
@@ -766,7 +765,6 @@ TEST_F(VisitedLinkEventsTest, IgnoreRendererCreationFromDifferentContext) {
WaitForCoalescense();
EXPECT_EQ(0, different_context.new_table_count());
-
}
} // namespace visitedlink

Powered by Google App Engine
This is Rietveld 408576698