Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 345023: Get rid of MessageLoop* caching in extensions code. (Closed)

Created:
11 years, 1 month ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review)
Visibility:
Public.

Description

Get rid of MessageLoop* caching in extensions code. BUG=25354 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30550

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -361 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_thread.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/download/download_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/extensions/crx_installer.h View 5 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 13 chunks +39 lines, -34 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_infobar_delegate.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_updater.h View 4 chunks +2 lines, -13 lines 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 9 chunks +41 lines, -58 lines 0 comments Download
M chrome/browser/extensions/extension_updater_unittest.cc View 11 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/extensions/extensions_service.h View 5 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 17 chunks +66 lines, -59 lines 0 comments Download
M chrome/browser/extensions/extensions_service_unittest.cc View 8 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/image_loading_tracker.cc View 5 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/extensions/pack_extension_job.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/pack_extension_job.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker.cc View 3 chunks +7 lines, -6 lines 0 comments Download
MM chrome/browser/extensions/user_script_listener.h View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.cc View 8 chunks +19 lines, -24 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/extensions/user_script_master.h View 5 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 4 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/extensions/user_script_master_unittest.cc View 6 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/profile.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/utility_process_host.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/utility_process_host.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/utility_process_host_unittest.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
11 years, 1 month ago (2009-10-29 22:20:45 UTC) #1
jam
Sending to the correct email.
11 years, 1 month ago (2009-10-29 22:28:49 UTC) #2
Aaron Boodman
11 years, 1 month ago (2009-10-30 00:56:07 UTC) #3 
lgtm

very cool

Powered by Google App Engine
This is Rietveld 408576698