Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/extensions/pack_extension_job.cc

Issue 345023: Get rid of MessageLoop* caching in extensions code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/pack_extension_job.cc
===================================================================
--- chrome/browser/extensions/pack_extension_job.cc (revision 30521)
+++ chrome/browser/extensions/pack_extension_job.cc (working copy)
@@ -7,14 +7,13 @@
#include "base/message_loop.h"
#include "base/string_util.h"
#include "base/task.h"
-#include "chrome/browser/chrome_thread.h"
#include "chrome/browser/extensions/extension_creator.h"
PackExtensionJob::PackExtensionJob(Client* client,
const FilePath& root_directory,
const FilePath& key_file)
- : ui_loop_(MessageLoop::current()), client_(client),
- root_directory_(root_directory), key_file_(key_file) {
+ : client_(client), root_directory_(root_directory), key_file_(key_file) {
+ CHECK(ChromeThread::GetCurrentThreadIdentifier(&client_thread_id_));
ChromeThread::PostTask(
ChromeThread::FILE, FROM_HERE,
NewRunnableMethod(this, &PackExtensionJob::RunOnFileThread));
@@ -34,11 +33,15 @@
// returns. See bug 20734.
ExtensionCreator creator;
if (creator.Run(root_directory_, crx_file_out_, key_file_, key_file_out_)) {
- ui_loop_->PostTask(FROM_HERE, NewRunnableMethod(this,
- &PackExtensionJob::ReportSuccessOnUIThread));
+ ChromeThread::PostTask(
+ client_thread_id_, FROM_HERE,
+ NewRunnableMethod(this, &PackExtensionJob::ReportSuccessOnUIThread));
} else {
- ui_loop_->PostTask(FROM_HERE, NewRunnableMethod(this,
- &PackExtensionJob::ReportFailureOnUIThread, creator.error_message()));
+ ChromeThread::PostTask(
+ client_thread_id_, FROM_HERE,
+ NewRunnableMethod(
+ this, &PackExtensionJob::ReportFailureOnUIThread,
+ creator.error_message()));
}
}
« no previous file with comments | « chrome/browser/extensions/pack_extension_job.h ('k') | chrome/browser/extensions/sandboxed_extension_unpacker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698