Get rid of MessageLoop* caching in extensions code.

chrome/browser/extensions/crx_installer.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 
 #include <string>
 
 #include "base/file_path.h"
-#include "base/message_loop.h"
 #include "base/ref_counted.h"
 #include "base/task.h"
 #include "chrome/browser/extensions/extension_install_ui.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/browser/extensions/sandboxed_extension_unpacker.h"
 #include "chrome/common/extensions/extension.h"
 
 class SkBitmap;
 
 // This class installs a crx file into a profile.
@@ skipping 19 matching lines @@
  public:
   // Starts the installation of the crx file in |crx_path| into
   // |install_directory|.
   //
   // Other params:
   //  install_source: The source of the install (external, --load-extension, etc
   //  expected_id: Optional. If the caller knows what the ID of this extension
   //               should be after unpacking, it can be specified here as a
   //               sanity check.
   //  delete_crx: Whether the crx should be deleted on completion.
-  //  file_loop: The message loop to do file IO on.
   //  frontend: The ExtensionsService to report the successfully installed
   //            extension to.
   //  client: Optional. If specified, will be used to confirm installation and
   //          also notified of success/fail. Note that we hold a reference to
   //          this, so it can outlive its creator (eg the UI).
   static void Start(const FilePath& crx_path,
                     const FilePath& install_directory,
                     Extension::Location install_source,
                     const std::string& expected_id,
                     bool delete_crx,
                     bool allow_privilege_increase,
-                    MessageLoop* file_loop,
                     ExtensionsService* frontend,
                     ExtensionInstallUI* client);
 
   // Given the path to the large icon from an extension, read it if present and
   // decode it into result.
   static void DecodeInstallIcon(const FilePath& large_icon_path,
                                 scoped_ptr<SkBitmap>* result);
 
   // ExtensionInstallUI::Delegate
   virtual void ContinueInstall();
   virtual void AbortInstall();
 
  private:
   CrxInstaller(const FilePath& crx_path,
                const FilePath& install_directory,
                Extension::Location install_source,
                const std::string& expected_id,
                bool delete_crx,
                bool allow_privilege_increase,
-               MessageLoop* file_loop,
                ExtensionsService* frontend,
                ExtensionInstallUI* client);
   ~CrxInstaller();
 
   // SandboxedExtensionUnpackerClient
   virtual void OnUnpackFailure(const std::string& error_message);
   virtual void OnUnpackSuccess(const FilePath& temp_dir,
                                const FilePath& extension_dir,
                                Extension* extension);
 
@@ skipping 33 matching lines @@
   // allowed.
   bool extensions_enabled_;
 
   // Whether we're supposed to delete the source crx file on destruction.
   bool delete_crx_;
 
   // Whether privileges should be allowed to silently increaes from any
   // previously installed version of the extension.
   bool allow_privilege_increase_;
 
-  // The message loop to use for file IO.
-  MessageLoop* file_loop_;
-
-  // The message loop the UI is running on.
-  MessageLoop* ui_loop_;
-
   // The extension we're installing. We own this and either pass it off to
   // ExtensionsService on success, or delete it on failure.
   scoped_ptr<Extension> extension_;
 
   // If non-empty, contains the current version of the extension we're
   // installing (for upgrades).
   std::string current_version_;
 
   // The icon we will display in the installation UI, if any.
   scoped_ptr<SkBitmap> install_icon_;
@@ skipping 13 matching lines @@
   // temp_dir_, so we don't have to delete it explicitly.
   FilePath unpacked_extension_root_;
 
   // The unpacker we will use to unpack the extension.
   SandboxedExtensionUnpacker* unpacker_;
 
   DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_