Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: chrome/browser/extensions/user_script_master_unittest.cc

Issue 345023: Get rid of MessageLoop* caching in extensions code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/user_script_master.cc ('k') | chrome/browser/profile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/user_script_master_unittest.cc
===================================================================
--- chrome/browser/extensions/user_script_master_unittest.cc (revision 30521)
+++ chrome/browser/extensions/user_script_master_unittest.cc (working copy)
@@ -11,6 +11,7 @@
#include "base/message_loop.h"
#include "base/path_service.h"
#include "base/string_util.h"
+#include "chrome/browser/chrome_thread.h"
#include "chrome/common/notification_registrar.h"
#include "chrome/common/notification_service.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -39,12 +40,18 @@
// Register for all user script notifications.
registrar_.Add(this, NotificationType::USER_SCRIPTS_UPDATED,
NotificationService::AllSources());
+
+ // UserScriptMaster posts tasks to the file thread so make the current
+ // thread look like one.
+ file_thread_.reset(new ChromeThread(
+ ChromeThread::FILE, MessageLoop::current()));
}
virtual void TearDown() {
// Clean up test directory.
ASSERT_TRUE(file_util::Delete(script_dir_, true));
ASSERT_FALSE(file_util::PathExists(script_dir_));
+ file_thread_.reset();
}
virtual void Observe(NotificationType type,
@@ -62,6 +69,8 @@
// MessageLoop used in tests.
MessageLoop message_loop_;
+ scoped_ptr<ChromeThread> file_thread_;
+
// Directory containing user scripts.
FilePath script_dir_;
@@ -71,9 +80,7 @@
// Test that we get notified even when there are no scripts.
TEST_F(UserScriptMasterTest, NoScripts) {
-
- scoped_refptr<UserScriptMaster> master(
- new UserScriptMaster(MessageLoop::current(), script_dir_));
+ scoped_refptr<UserScriptMaster> master(new UserScriptMaster(script_dir_));
master->StartScan();
message_loop_.PostTask(FROM_HERE, new MessageLoop::QuitTask);
message_loop_.Run();
@@ -85,8 +92,7 @@
#if defined(OS_WIN) || defined(OS_MACOSX)
// Test that we get notified about new scripts after they're added.
TEST_F(UserScriptMasterTest, NewScripts) {
- scoped_refptr<UserScriptMaster> master(
- new UserScriptMaster(MessageLoop::current(), script_dir_));
+ scoped_refptr<UserScriptMaster> master(new UserScriptMaster(script_dir_));
FilePath path = script_dir_.AppendASCII("script.user.js");
@@ -112,8 +118,7 @@
size_t written = file_util::WriteFile(path, content, sizeof(content));
ASSERT_EQ(written, sizeof(content));
- scoped_refptr<UserScriptMaster> master(
- new UserScriptMaster(MessageLoop::current(), script_dir_));
+ scoped_refptr<UserScriptMaster> master(new UserScriptMaster(script_dir_));
master->StartScan();
message_loop_.PostTask(FROM_HERE, new MessageLoop::QuitTask);
« no previous file with comments | « chrome/browser/extensions/user_script_master.cc ('k') | chrome/browser/profile.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698