Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2288)

Unified Diff: chrome/browser/extensions/extension_updater.h

Issue 345023: Get rid of MessageLoop* caching in extensions code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_updater.h
===================================================================
--- chrome/browser/extensions/extension_updater.h (revision 30521)
+++ chrome/browser/extensions/extension_updater.h (working copy)
@@ -22,7 +22,6 @@
class Extension;
class ExtensionUpdaterTest;
-class MessageLoop;
class ExtensionUpdaterFileHandler;
class PrefService;
@@ -30,9 +29,7 @@
//
// ExtensionUpdater* updater = new ExtensionUpdater(my_extensions_service,
// pref_service,
-// update_frequency_secs,
-// file_io_loop,
-// io_loop);
+// update_frequency_secs);
// updater.Start();
// ....
// updater.Stop();
@@ -45,9 +42,7 @@
// controls how often update checks are scheduled.
ExtensionUpdater(ExtensionUpdateService* service,
PrefService* prefs,
- int frequency_seconds,
- MessageLoop* file_io_loop,
- MessageLoop* io_loop);
+ int frequency_seconds);
virtual ~ExtensionUpdater();
@@ -178,12 +173,6 @@
base::OneShotTimer<ExtensionUpdater> timer_;
int frequency_seconds_;
- // The MessageLoop where we should do file I/O.
- MessageLoop* file_io_loop_;
-
- // The IO loop for IPC.
- MessageLoop* io_loop_;
-
PrefService* prefs_;
scoped_refptr<ExtensionUpdaterFileHandler> file_handler_;
« no previous file with comments | « chrome/browser/extensions/extension_message_service.cc ('k') | chrome/browser/extensions/extension_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698