Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1943)

Unified Diff: chrome/browser/extensions/extensions_service.h

Issue 345023: Get rid of MessageLoop* caching in extensions code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_service.h
===================================================================
--- chrome/browser/extensions/extensions_service.h (revision 30521)
+++ chrome/browser/extensions/extensions_service.h (working copy)
@@ -29,7 +29,6 @@
class ExtensionsServiceBackend;
class ExtensionUpdater;
class GURL;
-class MessageLoop;
class PrefService;
class Profile;
class ResourceDispatcherHost;
@@ -81,8 +80,6 @@
const CommandLine* command_line,
PrefService* prefs,
const FilePath& install_directory,
- MessageLoop* frontend_loop,
- MessageLoop* backend_loop,
bool autoupdate_enabled);
virtual ~ExtensionsService();
@@ -247,9 +244,6 @@
// Preferences for the owning profile.
scoped_ptr<ExtensionPrefs> extension_prefs_;
- // The message loop to use with the backend.
- MessageLoop* backend_loop_;
-
// The current list of installed extensions.
ExtensionList extensions_;
@@ -286,8 +280,7 @@
// |rdh| can be NULL in the case of test environment.
// |extension_prefs| contains a dictionary value that points to the extension
// preferences.
- ExtensionsServiceBackend(const FilePath& install_directory,
- MessageLoop* frontend_loop);
+ ExtensionsServiceBackend(const FilePath& install_directory);
virtual ~ExtensionsServiceBackend();
@@ -366,9 +359,6 @@
// Whether errors result in noisy alerts.
bool alert_on_error_;
- // The message loop to use to call the frontend.
- MessageLoop* frontend_loop_;
-
// A map of all external extension providers.
typedef std::map<Extension::Location,
linked_ptr<ExternalExtensionProvider> > ProviderMap;
« no previous file with comments | « chrome/browser/extensions/extension_updater_unittest.cc ('k') | chrome/browser/extensions/extensions_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698