Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Unified Diff: chrome/browser/extensions/crx_installer.h

Issue 345023: Get rid of MessageLoop* caching in extensions code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_manager.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.h
===================================================================
--- chrome/browser/extensions/crx_installer.h (revision 30521)
+++ chrome/browser/extensions/crx_installer.h (working copy)
@@ -8,7 +8,6 @@
#include <string>
#include "base/file_path.h"
-#include "base/message_loop.h"
#include "base/ref_counted.h"
#include "base/task.h"
#include "chrome/browser/extensions/extension_install_ui.h"
@@ -48,7 +47,6 @@
// should be after unpacking, it can be specified here as a
// sanity check.
// delete_crx: Whether the crx should be deleted on completion.
- // file_loop: The message loop to do file IO on.
// frontend: The ExtensionsService to report the successfully installed
// extension to.
// client: Optional. If specified, will be used to confirm installation and
@@ -60,7 +58,6 @@
const std::string& expected_id,
bool delete_crx,
bool allow_privilege_increase,
- MessageLoop* file_loop,
ExtensionsService* frontend,
ExtensionInstallUI* client);
@@ -80,7 +77,6 @@
const std::string& expected_id,
bool delete_crx,
bool allow_privilege_increase,
- MessageLoop* file_loop,
ExtensionsService* frontend,
ExtensionInstallUI* client);
~CrxInstaller();
@@ -134,12 +130,6 @@
// previously installed version of the extension.
bool allow_privilege_increase_;
- // The message loop to use for file IO.
- MessageLoop* file_loop_;
-
- // The message loop the UI is running on.
- MessageLoop* ui_loop_;
-
// The extension we're installing. We own this and either pass it off to
// ExtensionsService on success, or delete it on failure.
scoped_ptr<Extension> extension_;
Property changes on: chrome\browser\extensions\crx_installer.h
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « chrome/browser/download/download_manager.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698