Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 32823017: Move FloatPolygon.* and WindRule.h to Source/platform/ (Closed)

Created:
7 years, 2 months ago by rwlbuis
Modified:
7 years, 2 months ago
CC:
blink-reviews, jamesr, zoltan1, dsinclair, eae+blinkwatch, leviw+renderwatch, danakj, dglazkov+blink, Rik, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, Stephen Chennney, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move FloatPolygon.* and WindRule.h to Source/platform/ BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160377

Patch Set 1 #

Patch Set 2 : Create a HTMLUnknownElement when using createElement('image') #

Patch Set 3 : Export classes/enum for win/mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -473 lines) Patch
M Source/core/core.gyp View 2 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/core.gypi View 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSBasicShapes.h View 2 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/graphics/FloatPolygon.h View 2 1 chunk +0 lines, -153 lines 0 comments Download
D Source/core/platform/graphics/FloatPolygon.cpp View 2 1 chunk +0 lines, -254 lines 0 comments Download
M Source/core/platform/graphics/Path.h View 2 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/graphics/WindRule.h View 2 1 chunk +0 lines, -41 lines 0 comments Download
M Source/core/rendering/shapes/PolygonShape.h View 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/shapes/Shape.cpp View 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/BasicShapes.h View 2 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 2 2 chunks +3 lines, -0 lines 0 comments Download
A + Source/platform/geometry/FloatPolygon.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
A + Source/platform/geometry/FloatPolygon.cpp View 2 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/WindRule.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
do_not_use
Works on my linux build.
7 years, 2 months ago (2013-10-23 15:40:04 UTC) #1
eseidel
lgtm
7 years, 2 months ago (2013-10-23 16:26:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/32823017/1
7 years, 2 months ago (2013-10-23 16:26:20 UTC) #3
rwlbuis
Hopefully this fixes the Mac+win build issues reported by the bots.
7 years, 2 months ago (2013-10-23 18:54:20 UTC) #4
eseidel
lgtm If the bots like it, I do.
7 years, 2 months ago (2013-10-23 18:55:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/32823017/150001
7 years, 2 months ago (2013-10-23 18:56:07 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 20:28:12 UTC) #7
Message was sent while issue was closed.
Change committed as 160377

Powered by Google App Engine
This is Rietveld 408576698