Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 321023002: Avoid branching in createAttributeEventListener (Closed)

Created:
6 years, 6 months ago by rwlbuis
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, shans, fs, Steve Block, rwlbuis, krit, arv+blink, blink-reviews-html_chromium.org, dglazkov+blink, abarth-chromium, dstockwell, Timothy Loh, blink-reviews-bindings_chromium.org, pdr., Eric Willigers, rjwright, gyuyoung.kim_webkit.org, darktears, blink-reviews-animation_chromium.org, kouhei+svg_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Avoid branching in createAttributeEventListener Avoid branching in createAttributeEventListener, also it should not be needed to test for SVG specific stuff in this spot. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175902

Patch Set 1 #

Patch Set 2 : Remove leftover line #

Total comments: 2

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -68 lines) Patch
M Source/bindings/v8/ScriptEventListener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptEventListener.cpp View 1 3 chunks +4 lines, -11 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 chunk +19 lines, -19 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +20 lines, -20 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rwlbuis
PTAL, it is a simple refactor, hopefully cleaner, but there may be even better ways ...
6 years, 6 months ago (2014-06-10 14:54:21 UTC) #1
haraken
LGTM with comments. Let's remove eventParameterName() from ScriptEventListener.cpp. It does the same work as eventParameterName() ...
6 years, 6 months ago (2014-06-10 15:05:33 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 6 months ago (2014-06-10 15:47:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/321023002/40001
6 years, 6 months ago (2014-06-10 15:49:07 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 16:57:59 UTC) #5
Message was sent while issue was closed. 
Change committed as 175902

Powered by Google App Engine
This is Rietveld 408576698