Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 321023002: Avoid branching in createAttributeEventListener (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGScriptElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 521 matching lines...) Expand 10 before | Expand all | Expand 10 after
532 connectSyncBaseConditions(); 532 connectSyncBaseConditions();
533 } else if (name == SVGNames::endAttr) { 533 } else if (name == SVGNames::endAttr) {
534 if (!m_conditions.isEmpty()) { 534 if (!m_conditions.isEmpty()) {
535 clearConditions(); 535 clearConditions();
536 parseBeginOrEnd(fastGetAttribute(SVGNames::beginAttr), Begin); 536 parseBeginOrEnd(fastGetAttribute(SVGNames::beginAttr), Begin);
537 } 537 }
538 parseBeginOrEnd(value.string(), End); 538 parseBeginOrEnd(value.string(), End);
539 if (inDocument()) 539 if (inDocument())
540 connectSyncBaseConditions(); 540 connectSyncBaseConditions();
541 } else if (name == SVGNames::onbeginAttr) { 541 } else if (name == SVGNames::onbeginAttr) {
542 setAttributeEventListener(EventTypeNames::beginEvent, createAttributeEve ntListener(this, name, value)); 542 setAttributeEventListener(EventTypeNames::beginEvent, createAttributeEve ntListener(this, name, value, eventParameterName()));
543 } else if (name == SVGNames::onendAttr) { 543 } else if (name == SVGNames::onendAttr) {
544 setAttributeEventListener(EventTypeNames::endEvent, createAttributeEvent Listener(this, name, value)); 544 setAttributeEventListener(EventTypeNames::endEvent, createAttributeEvent Listener(this, name, value, eventParameterName()));
545 } else if (name == SVGNames::onrepeatAttr) { 545 } else if (name == SVGNames::onrepeatAttr) {
546 setAttributeEventListener(EventTypeNames::repeatEvent, createAttributeEv entListener(this, name, value)); 546 setAttributeEventListener(EventTypeNames::repeatEvent, createAttributeEv entListener(this, name, value, eventParameterName()));
547 } else 547 } else
548 SVGElement::parseAttribute(name, value); 548 SVGElement::parseAttribute(name, value);
549 } 549 }
550 550
551 void SVGSMILElement::svgAttributeChanged(const QualifiedName& attrName) 551 void SVGSMILElement::svgAttributeChanged(const QualifiedName& attrName)
552 { 552 {
553 if (!isSupportedAttribute(attrName)) { 553 if (!isSupportedAttribute(attrName)) {
554 SVGElement::svgAttributeChanged(attrName); 554 SVGElement::svgAttributeChanged(attrName);
555 return; 555 return;
556 } 556 }
(...skipping 789 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 void SVGSMILElement::trace(Visitor* visitor) 1346 void SVGSMILElement::trace(Visitor* visitor)
1347 { 1347 {
1348 visitor->trace(m_targetElement); 1348 visitor->trace(m_targetElement);
1349 visitor->trace(m_timeContainer); 1349 visitor->trace(m_timeContainer);
1350 visitor->trace(m_conditions); 1350 visitor->trace(m_conditions);
1351 visitor->trace(m_syncBaseDependents); 1351 visitor->trace(m_syncBaseDependents);
1352 SVGElement::trace(visitor); 1352 SVGElement::trace(visitor);
1353 } 1353 }
1354 1354
1355 } 1355 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGScriptElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698