Source/bindings/v8/ScriptEventListener.h - Issue 321023002: Avoid branching in createAttributeEventListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptEventListener.h

Issue 321023002: Avoid branching in createAttributeEventListener (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/ScriptEventListener.h

diff --git a/Source/bindings/v8/ScriptEventListener.h b/Source/bindings/v8/ScriptEventListener.h

index 0bb2e997c624afb5faa2ff1be9fcdc3c3578ab66..097675defbd2ff58e8fad9808bd191be6dc72b5a 100644

--- a/Source/bindings/v8/ScriptEventListener.h

+++ b/Source/bindings/v8/ScriptEventListener.h

@@ -43,8 +43,8 @@ namespace WebCore {

class Node;

class QualifiedName;

- PassRefPtr<V8LazyEventListener> createAttributeEventListener(Node*, const QualifiedName&, const AtomicString& value);

- PassRefPtr<V8LazyEventListener> createAttributeEventListener(LocalFrame*, const QualifiedName&, const AtomicString& value);

+ PassRefPtr<V8LazyEventListener> createAttributeEventListener(Node*, const QualifiedName&, const AtomicString& value, const AtomicString& eventParameterName);

+ PassRefPtr<V8LazyEventListener> createAttributeEventListener(LocalFrame*, const QualifiedName&, const AtomicString& value, const AtomicString& eventParameterName);

String eventListenerHandlerBody(Document*, EventListener*);

ScriptValue eventListenerHandler(Document*, EventListener*);

ScriptState* eventListenerHandlerScriptState(LocalFrame*, EventListener*);

« no previous file with comments | « no previous file | Source/bindings/v8/ScriptEventListener.cpp » ('j') | no next file with comments »