Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 321023002: Avoid branching in createAttributeEventListener (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLFrameSetElement.cpp ('k') | Source/core/svg/SVGElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 if (m_size != oldSize && renderer()) 661 if (m_size != oldSize && renderer())
662 renderer()->setNeedsLayoutAndPrefWidthsRecalcAndFullRepaint(); 662 renderer()->setNeedsLayoutAndPrefWidthsRecalcAndFullRepaint();
663 } else if (name == altAttr) 663 } else if (name == altAttr)
664 m_inputTypeView->altAttributeChanged(); 664 m_inputTypeView->altAttributeChanged();
665 else if (name == srcAttr) 665 else if (name == srcAttr)
666 m_inputTypeView->srcAttributeChanged(); 666 m_inputTypeView->srcAttributeChanged();
667 else if (name == usemapAttr || name == accesskeyAttr) { 667 else if (name == usemapAttr || name == accesskeyAttr) {
668 // FIXME: ignore for the moment 668 // FIXME: ignore for the moment
669 } else if (name == onsearchAttr) { 669 } else if (name == onsearchAttr) {
670 // Search field and slider attributes all just cause updateFromElement t o be called through style recalcing. 670 // Search field and slider attributes all just cause updateFromElement t o be called through style recalcing.
671 setAttributeEventListener(EventTypeNames::search, createAttributeEventLi stener(this, name, value)); 671 setAttributeEventListener(EventTypeNames::search, createAttributeEventLi stener(this, name, value, eventParameterName()));
672 } else if (name == resultsAttr) { 672 } else if (name == resultsAttr) {
673 int oldResults = m_maxResults; 673 int oldResults = m_maxResults;
674 m_maxResults = !value.isNull() ? std::min(value.toInt(), maxSavedResults ) : -1; 674 m_maxResults = !value.isNull() ? std::min(value.toInt(), maxSavedResults ) : -1;
675 // FIXME: Detaching just for maxResults change is not ideal. We should figure out the right 675 // FIXME: Detaching just for maxResults change is not ideal. We should figure out the right
676 // time to relayout for this change. 676 // time to relayout for this change.
677 if (m_maxResults != oldResults && (m_maxResults <= 0 || oldResults <= 0) ) 677 if (m_maxResults != oldResults && (m_maxResults <= 0 || oldResults <= 0) )
678 lazyReattachIfAttached(); 678 lazyReattachIfAttached();
679 setNeedsStyleRecalc(SubtreeStyleChange); 679 setNeedsStyleRecalc(SubtreeStyleChange);
680 UseCounter::count(document(), UseCounter::ResultsAttribute); 680 UseCounter::count(document(), UseCounter::ResultsAttribute);
681 } else if (name == incrementalAttr) { 681 } else if (name == incrementalAttr) {
(...skipping 1176 matching lines...) Expand 10 before | Expand all | Expand 10 after
1858 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer()); 1858 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());
1859 } 1859 }
1860 #endif 1860 #endif
1861 1861
1862 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue) 1862 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue)
1863 { 1863 {
1864 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ; 1864 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ;
1865 } 1865 }
1866 1866
1867 } // namespace 1867 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFrameSetElement.cpp ('k') | Source/core/svg/SVGElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698