Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: Source/core/svg/SVGScriptElement.cpp

Issue 321023002: Avoid branching in createAttributeEventListener (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGSVGElement.cpp ('k') | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 if (!isSupportedAttribute(name)) { 61 if (!isSupportedAttribute(name)) {
62 SVGElement::parseAttribute(name, value); 62 SVGElement::parseAttribute(name, value);
63 return; 63 return;
64 } 64 }
65 65
66 SVGParsingError parseError = NoError; 66 SVGParsingError parseError = NoError;
67 if (name == SVGNames::typeAttr) 67 if (name == SVGNames::typeAttr)
68 return; 68 return;
69 69
70 if (name == HTMLNames::onerrorAttr) { 70 if (name == HTMLNames::onerrorAttr) {
71 setAttributeEventListener(EventTypeNames::error, createAttributeEventLis tener(this, name, value)); 71 setAttributeEventListener(EventTypeNames::error, createAttributeEventLis tener(this, name, value, eventParameterName()));
72 } else if (SVGURIReference::parseAttribute(name, value, parseError)) { 72 } else if (SVGURIReference::parseAttribute(name, value, parseError)) {
73 } else { 73 } else {
74 ASSERT_NOT_REACHED(); 74 ASSERT_NOT_REACHED();
75 } 75 }
76 76
77 reportAttributeParsingError(parseError, name, value); 77 reportAttributeParsingError(parseError, name, value);
78 } 78 }
79 79
80 void SVGScriptElement::svgAttributeChanged(const QualifiedName& attrName) 80 void SVGScriptElement::svgAttributeChanged(const QualifiedName& attrName)
81 { 81 {
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 bool SVGScriptElement::isAnimatableAttribute(const QualifiedName& name) const 194 bool SVGScriptElement::isAnimatableAttribute(const QualifiedName& name) const
195 { 195 {
196 if (name == SVGNames::typeAttr) 196 if (name == SVGNames::typeAttr)
197 return false; 197 return false;
198 198
199 return SVGElement::isAnimatableAttribute(name); 199 return SVGElement::isAnimatableAttribute(name);
200 } 200 }
201 #endif 201 #endif
202 202
203 } 203 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGSVGElement.cpp ('k') | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698