Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Side by Side Diff: Source/core/svg/SVGSVGElement.cpp

Issue 321023002: Avoid branching in createAttributeEventListener (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | Source/core/svg/SVGScriptElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2007 Apple Inc. All rights reserved.
5 * Copyright (C) 2014 Google, Inc. 5 * Copyright (C) 2014 Google, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 211
212 void SVGSVGElement::parseAttribute(const QualifiedName& name, const AtomicString & value) 212 void SVGSVGElement::parseAttribute(const QualifiedName& name, const AtomicString & value)
213 { 213 {
214 SVGParsingError parseError = NoError; 214 SVGParsingError parseError = NoError;
215 215
216 if (!nearestViewportElement()) { 216 if (!nearestViewportElement()) {
217 bool setListener = true; 217 bool setListener = true;
218 218
219 // Only handle events if we're the outermost <svg> element 219 // Only handle events if we're the outermost <svg> element
220 if (name == HTMLNames::onunloadAttr) 220 if (name == HTMLNames::onunloadAttr)
221 document().setWindowAttributeEventListener(EventTypeNames::unload, c reateAttributeEventListener(document().frame(), name, value)); 221 document().setWindowAttributeEventListener(EventTypeNames::unload, c reateAttributeEventListener(document().frame(), name, value, eventParameterName( )));
222 else if (name == HTMLNames::onresizeAttr) 222 else if (name == HTMLNames::onresizeAttr)
223 document().setWindowAttributeEventListener(EventTypeNames::resize, c reateAttributeEventListener(document().frame(), name, value)); 223 document().setWindowAttributeEventListener(EventTypeNames::resize, c reateAttributeEventListener(document().frame(), name, value, eventParameterName( )));
224 else if (name == HTMLNames::onscrollAttr) 224 else if (name == HTMLNames::onscrollAttr)
225 document().setWindowAttributeEventListener(EventTypeNames::scroll, c reateAttributeEventListener(document().frame(), name, value)); 225 document().setWindowAttributeEventListener(EventTypeNames::scroll, c reateAttributeEventListener(document().frame(), name, value, eventParameterName( )));
226 else if (name == SVGNames::onzoomAttr) 226 else if (name == SVGNames::onzoomAttr)
227 document().setWindowAttributeEventListener(EventTypeNames::zoom, cre ateAttributeEventListener(document().frame(), name, value)); 227 document().setWindowAttributeEventListener(EventTypeNames::zoom, cre ateAttributeEventListener(document().frame(), name, value, eventParameterName()) );
228 else 228 else
229 setListener = false; 229 setListener = false;
230 230
231 if (setListener) 231 if (setListener)
232 return; 232 return;
233 } 233 }
234 234
235 if (name == HTMLNames::onabortAttr) { 235 if (name == HTMLNames::onabortAttr) {
236 document().setWindowAttributeEventListener(EventTypeNames::abort, create AttributeEventListener(document().frame(), name, value)); 236 document().setWindowAttributeEventListener(EventTypeNames::abort, create AttributeEventListener(document().frame(), name, value, eventParameterName()));
237 } else if (name == HTMLNames::onerrorAttr) { 237 } else if (name == HTMLNames::onerrorAttr) {
238 document().setWindowAttributeEventListener(EventTypeNames::error, create AttributeEventListener(document().frame(), name, value)); 238 document().setWindowAttributeEventListener(EventTypeNames::error, create AttributeEventListener(document().frame(), name, value, eventParameterName()));
239 } else if (name == SVGNames::xAttr) { 239 } else if (name == SVGNames::xAttr) {
240 m_x->setBaseValueAsString(value, parseError); 240 m_x->setBaseValueAsString(value, parseError);
241 } else if (name == SVGNames::yAttr) { 241 } else if (name == SVGNames::yAttr) {
242 m_y->setBaseValueAsString(value, parseError); 242 m_y->setBaseValueAsString(value, parseError);
243 } else if (name == SVGNames::widthAttr) { 243 } else if (name == SVGNames::widthAttr) {
244 m_width->setBaseValueAsString(value, parseError); 244 m_width->setBaseValueAsString(value, parseError);
245 } else if (name == SVGNames::heightAttr) { 245 } else if (name == SVGNames::heightAttr) {
246 m_height->setBaseValueAsString(value, parseError); 246 m_height->setBaseValueAsString(value, parseError);
247 } else if (SVGFitToViewBox::parseAttribute(name, value, document(), parseErr or)) { 247 } else if (SVGFitToViewBox::parseAttribute(name, value, document(), parseErr or)) {
248 } else if (SVGZoomAndPan::parseAttribute(name, value)) { 248 } else if (SVGZoomAndPan::parseAttribute(name, value)) {
(...skipping 530 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 } 779 }
780 780
781 void SVGSVGElement::trace(Visitor* visitor) 781 void SVGSVGElement::trace(Visitor* visitor)
782 { 782 {
783 visitor->trace(m_timeContainer); 783 visitor->trace(m_timeContainer);
784 visitor->trace(m_viewSpec); 784 visitor->trace(m_viewSpec);
785 SVGGraphicsElement::trace(visitor); 785 SVGGraphicsElement::trace(visitor);
786 } 786 }
787 787
788 } 788 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | Source/core/svg/SVGScriptElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698