Source/core/svg/SVGSVGElement.cpp - Issue 321023002: Avoid branching in createAttributeEventListener

Unified Diff: Source/core/svg/SVGSVGElement.cpp

Issue 321023002: Avoid branching in createAttributeEventListener (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGSVGElement.cpp

diff --git a/Source/core/svg/SVGSVGElement.cpp b/Source/core/svg/SVGSVGElement.cpp

index 357c6387e0084c169178b490d9992531d7ed3b77..82e7c607fd9bf00528c9ffcc039aab385f5f2582 100644

--- a/Source/core/svg/SVGSVGElement.cpp

+++ b/Source/core/svg/SVGSVGElement.cpp

@@ -218,13 +218,13 @@ void SVGSVGElement::parseAttribute(const QualifiedName& name, const AtomicString

// Only handle events if we're the outermost <svg> element

if (name == HTMLNames::onunloadAttr)

- document().setWindowAttributeEventListener(EventTypeNames::unload, createAttributeEventListener(document().frame(), name, value));

+ document().setWindowAttributeEventListener(EventTypeNames::unload, createAttributeEventListener(document().frame(), name, value, eventParameterName()));

else if (name == HTMLNames::onresizeAttr)

- document().setWindowAttributeEventListener(EventTypeNames::resize, createAttributeEventListener(document().frame(), name, value));

+ document().setWindowAttributeEventListener(EventTypeNames::resize, createAttributeEventListener(document().frame(), name, value, eventParameterName()));

else if (name == HTMLNames::onscrollAttr)

- document().setWindowAttributeEventListener(EventTypeNames::scroll, createAttributeEventListener(document().frame(), name, value));

+ document().setWindowAttributeEventListener(EventTypeNames::scroll, createAttributeEventListener(document().frame(), name, value, eventParameterName()));

else if (name == SVGNames::onzoomAttr)

- document().setWindowAttributeEventListener(EventTypeNames::zoom, createAttributeEventListener(document().frame(), name, value));

+ document().setWindowAttributeEventListener(EventTypeNames::zoom, createAttributeEventListener(document().frame(), name, value, eventParameterName()));

else

setListener = false;

@@ -233,9 +233,9 @@ void SVGSVGElement::parseAttribute(const QualifiedName& name, const AtomicString

}

if (name == HTMLNames::onabortAttr) {

- document().setWindowAttributeEventListener(EventTypeNames::abort, createAttributeEventListener(document().frame(), name, value));

+ document().setWindowAttributeEventListener(EventTypeNames::abort, createAttributeEventListener(document().frame(), name, value, eventParameterName()));

} else if (name == HTMLNames::onerrorAttr) {

- document().setWindowAttributeEventListener(EventTypeNames::error, createAttributeEventListener(document().frame(), name, value));

+ document().setWindowAttributeEventListener(EventTypeNames::error, createAttributeEventListener(document().frame(), name, value, eventParameterName()));

} else if (name == SVGNames::xAttr) {

m_x->setBaseValueAsString(value, parseError);

} else if (name == SVGNames::yAttr) {

« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | Source/core/svg/SVGScriptElement.cpp » ('j') | no next file with comments »