Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/core/html/HTMLFrameSetElement.cpp

Issue 321023002: Avoid branching in createAttributeEventListener (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLFrameElementBase.cpp ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann (hausmann@kde.org) 4 * (C) 2000 Simon Hausmann (hausmann@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2006, 2009, 2010 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2006, 2009, 2010 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 m_noresize = true; 101 m_noresize = true;
102 } else if (name == borderAttr) { 102 } else if (name == borderAttr) {
103 if (!value.isNull()) { 103 if (!value.isNull()) {
104 m_border = value.toInt(); 104 m_border = value.toInt();
105 m_borderSet = true; 105 m_borderSet = true;
106 } else 106 } else
107 m_borderSet = false; 107 m_borderSet = false;
108 } else if (name == bordercolorAttr) 108 } else if (name == bordercolorAttr)
109 m_borderColorSet = !value.isEmpty(); 109 m_borderColorSet = !value.isEmpty();
110 else if (name == onloadAttr) 110 else if (name == onloadAttr)
111 document().setWindowAttributeEventListener(EventTypeNames::load, createA ttributeEventListener(document().frame(), name, value)); 111 document().setWindowAttributeEventListener(EventTypeNames::load, createA ttributeEventListener(document().frame(), name, value, eventParameterName()));
112 else if (name == onbeforeunloadAttr) 112 else if (name == onbeforeunloadAttr)
113 document().setWindowAttributeEventListener(EventTypeNames::beforeunload, createAttributeEventListener(document().frame(), name, value)); 113 document().setWindowAttributeEventListener(EventTypeNames::beforeunload, createAttributeEventListener(document().frame(), name, value, eventParameterNam e()));
114 else if (name == onunloadAttr) 114 else if (name == onunloadAttr)
115 document().setWindowAttributeEventListener(EventTypeNames::unload, creat eAttributeEventListener(document().frame(), name, value)); 115 document().setWindowAttributeEventListener(EventTypeNames::unload, creat eAttributeEventListener(document().frame(), name, value, eventParameterName()));
116 else if (name == onpagehideAttr) 116 else if (name == onpagehideAttr)
117 document().setWindowAttributeEventListener(EventTypeNames::pagehide, cre ateAttributeEventListener(document().frame(), name, value)); 117 document().setWindowAttributeEventListener(EventTypeNames::pagehide, cre ateAttributeEventListener(document().frame(), name, value, eventParameterName()) );
118 else if (name == onpageshowAttr) 118 else if (name == onpageshowAttr)
119 document().setWindowAttributeEventListener(EventTypeNames::pageshow, cre ateAttributeEventListener(document().frame(), name, value)); 119 document().setWindowAttributeEventListener(EventTypeNames::pageshow, cre ateAttributeEventListener(document().frame(), name, value, eventParameterName()) );
120 else if (name == onblurAttr) 120 else if (name == onblurAttr)
121 document().setWindowAttributeEventListener(EventTypeNames::blur, createA ttributeEventListener(document().frame(), name, value)); 121 document().setWindowAttributeEventListener(EventTypeNames::blur, createA ttributeEventListener(document().frame(), name, value, eventParameterName()));
122 else if (name == onerrorAttr) 122 else if (name == onerrorAttr)
123 document().setWindowAttributeEventListener(EventTypeNames::error, create AttributeEventListener(document().frame(), name, value)); 123 document().setWindowAttributeEventListener(EventTypeNames::error, create AttributeEventListener(document().frame(), name, value, eventParameterName()));
124 else if (name == onfocusAttr) 124 else if (name == onfocusAttr)
125 document().setWindowAttributeEventListener(EventTypeNames::focus, create AttributeEventListener(document().frame(), name, value)); 125 document().setWindowAttributeEventListener(EventTypeNames::focus, create AttributeEventListener(document().frame(), name, value, eventParameterName()));
126 else if (name == onfocusinAttr) 126 else if (name == onfocusinAttr)
127 document().setWindowAttributeEventListener(EventTypeNames::focusin, crea teAttributeEventListener(document().frame(), name, value)); 127 document().setWindowAttributeEventListener(EventTypeNames::focusin, crea teAttributeEventListener(document().frame(), name, value, eventParameterName())) ;
128 else if (name == onfocusoutAttr) 128 else if (name == onfocusoutAttr)
129 document().setWindowAttributeEventListener(EventTypeNames::focusout, cre ateAttributeEventListener(document().frame(), name, value)); 129 document().setWindowAttributeEventListener(EventTypeNames::focusout, cre ateAttributeEventListener(document().frame(), name, value, eventParameterName()) );
130 else if (RuntimeEnabledFeatures::orientationEventEnabled() && name == onorie ntationchangeAttr) 130 else if (RuntimeEnabledFeatures::orientationEventEnabled() && name == onorie ntationchangeAttr)
131 document().setWindowAttributeEventListener(EventTypeNames::orientationch ange, createAttributeEventListener(document().frame(), name, value)); 131 document().setWindowAttributeEventListener(EventTypeNames::orientationch ange, createAttributeEventListener(document().frame(), name, value, eventParamet erName()));
132 else if (name == onhashchangeAttr) 132 else if (name == onhashchangeAttr)
133 document().setWindowAttributeEventListener(EventTypeNames::hashchange, c reateAttributeEventListener(document().frame(), name, value)); 133 document().setWindowAttributeEventListener(EventTypeNames::hashchange, c reateAttributeEventListener(document().frame(), name, value, eventParameterName( )));
134 else if (name == onmessageAttr) 134 else if (name == onmessageAttr)
135 document().setWindowAttributeEventListener(EventTypeNames::message, crea teAttributeEventListener(document().frame(), name, value)); 135 document().setWindowAttributeEventListener(EventTypeNames::message, crea teAttributeEventListener(document().frame(), name, value, eventParameterName())) ;
136 else if (name == onresizeAttr) 136 else if (name == onresizeAttr)
137 document().setWindowAttributeEventListener(EventTypeNames::resize, creat eAttributeEventListener(document().frame(), name, value)); 137 document().setWindowAttributeEventListener(EventTypeNames::resize, creat eAttributeEventListener(document().frame(), name, value, eventParameterName()));
138 else if (name == onscrollAttr) 138 else if (name == onscrollAttr)
139 document().setWindowAttributeEventListener(EventTypeNames::scroll, creat eAttributeEventListener(document().frame(), name, value)); 139 document().setWindowAttributeEventListener(EventTypeNames::scroll, creat eAttributeEventListener(document().frame(), name, value, eventParameterName()));
140 else if (name == onstorageAttr) 140 else if (name == onstorageAttr)
141 document().setWindowAttributeEventListener(EventTypeNames::storage, crea teAttributeEventListener(document().frame(), name, value)); 141 document().setWindowAttributeEventListener(EventTypeNames::storage, crea teAttributeEventListener(document().frame(), name, value, eventParameterName())) ;
142 else if (name == ononlineAttr) 142 else if (name == ononlineAttr)
143 document().setWindowAttributeEventListener(EventTypeNames::online, creat eAttributeEventListener(document().frame(), name, value)); 143 document().setWindowAttributeEventListener(EventTypeNames::online, creat eAttributeEventListener(document().frame(), name, value, eventParameterName()));
144 else if (name == onofflineAttr) 144 else if (name == onofflineAttr)
145 document().setWindowAttributeEventListener(EventTypeNames::offline, crea teAttributeEventListener(document().frame(), name, value)); 145 document().setWindowAttributeEventListener(EventTypeNames::offline, crea teAttributeEventListener(document().frame(), name, value, eventParameterName())) ;
146 else if (name == onpopstateAttr) 146 else if (name == onpopstateAttr)
147 document().setWindowAttributeEventListener(EventTypeNames::popstate, cre ateAttributeEventListener(document().frame(), name, value)); 147 document().setWindowAttributeEventListener(EventTypeNames::popstate, cre ateAttributeEventListener(document().frame(), name, value, eventParameterName()) );
148 else if (name == onlanguagechangeAttr) 148 else if (name == onlanguagechangeAttr)
149 document().setWindowAttributeEventListener(EventTypeNames::languagechang e, createAttributeEventListener(document().frame(), name, value)); 149 document().setWindowAttributeEventListener(EventTypeNames::languagechang e, createAttributeEventListener(document().frame(), name, value, eventParameterN ame()));
150 else 150 else
151 HTMLElement::parseAttribute(name, value); 151 HTMLElement::parseAttribute(name, value);
152 } 152 }
153 153
154 bool HTMLFrameSetElement::rendererIsNeeded(const RenderStyle& style) 154 bool HTMLFrameSetElement::rendererIsNeeded(const RenderStyle& style)
155 { 155 {
156 // For compatibility, frames render even when display: none is set. 156 // For compatibility, frames render even when display: none is set.
157 // However, we delay creating a renderer until stylesheets have loaded. 157 // However, we delay creating a renderer until stylesheets have loaded.
158 return style.isStyleAvailable(); 158 return style.isStyleAvailable();
159 } 159 }
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 Element* frameElement = children()->namedItem(name); 219 Element* frameElement = children()->namedItem(name);
220 if (!isHTMLFrameElement(frameElement)) 220 if (!isHTMLFrameElement(frameElement))
221 return 0; 221 return 0;
222 Document* document = toHTMLFrameElement(frameElement)->contentDocument(); 222 Document* document = toHTMLFrameElement(frameElement)->contentDocument();
223 if (!document || !document->frame()) 223 if (!document || !document->frame())
224 return 0; 224 return 0;
225 return document->domWindow(); 225 return document->domWindow();
226 } 226 }
227 227
228 } // namespace WebCore 228 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFrameElementBase.cpp ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698