scheduler: rename JobID to JobName to avoid overloading JobID meaning.

scheduler: rename JobID to JobName to avoid overloading JobID meaning.

This also renames recently landed GetJobs api Job.Id to Job.Name, and
hence is backwards incompatible, but it is OK API is still experimental.

R=vadimsh@chromium.org
Bug: 712427
Review-Url: https://codereview.chromium.org/2948103002
Committed: https://github.com/luci/luci-go/commit/4ab136ab49c856a5de394d15946eca3eb22143c0

[tandrii(chromium), 2017-06-21 16:13:27]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 16:13:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2017-06-21 16:16:08]

https://codereview.chromium.org/2948103002/diff/1/scheduler/appengine/engine/...
File scheduler/appengine/engine/engine.go (right):

https://codereview.chromium.org/2948103002/diff/1/scheduler/appengine/engine/...
scheduler/appengine/engine/engine.go:260: func (e *Job) GetJobName() string {
it seems you've meant to avoid public functions here, but it seems the logic of
splitting JobID really belongs to Job object itself.

[tandrii(chromium), 2017-06-21 16:17:19]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 16:17:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 16:27:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 16:27:54]

Dry run: This issue passed the CQ dry run.

[Vadim Sh., 2017-06-21 16:40:42]

lgtm with nit

https://codereview.chromium.org/2948103002/diff/20001/scheduler/appengine/fro...
File scheduler/appengine/frontend/templates/includes/base.html (right):

https://codereview.chromium.org/2948103002/diff/20001/scheduler/appengine/fro...
scheduler/appengine/frontend/templates/includes/base.html:102: var JobName =
$("input#JobName", form).val();
please keep it lowercase to conform to js naming style

[tandrii(chromium), 2017-06-21 16:47:03]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 16:47:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2017-06-21 16:51:18]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2017-06-21 16:51:18]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2948103002/#ps60001
(title: "more js lowercase")

[commit-bot: I haz the power, 2017-06-21 16:51:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2017-06-21 16:52:05]

https://codereview.chromium.org/2948103002/diff/20001/scheduler/appengine/fro...
File scheduler/appengine/frontend/templates/includes/base.html (right):

https://codereview.chromium.org/2948103002/diff/20001/scheduler/appengine/fro...
scheduler/appengine/frontend/templates/includes/base.html:102: var JobName =
$("input#JobName", form).val();
On 2017/06/21 16:40:42, Vadim Sh. wrote:
> please keep it lowercase to conform to js naming style

Done.

[commit-bot: I haz the power, 2017-06-21 17:02:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498063878110300,
"parent_rev": "325ef28b9e9377b739f17b134da4fc003d622449", "commit_rev":
"4ab136ab49c856a5de394d15946eca3eb22143c0"}

[commit-bot: I haz the power, 2017-06-21 17:02:20]

Description was changed from

==========
scheduler: rename JobID to JobName to avoid overloading JobID meaning.

This also renames recently landed GetJobs api Job.Id to Job.Name, and
hence is backwards incompatible, but it is OK API is still experimental.

R=vadimsh@chromium.org
Bug: 712427
==========

to

==========
scheduler: rename JobID to JobName to avoid overloading JobID meaning.

This also renames recently landed GetJobs api Job.Id to Job.Name, and
hence is backwards incompatible, but it is OK API is still experimental.

R=vadimsh@chromium.org
Bug: 712427
Review-Url: https://codereview.chromium.org/2948103002
Committed:
https://github.com/luci/luci-go/commit/4ab136ab49c856a5de394d15946eca3eb22143c0
==========

[commit-bot: I haz the power, 2017-06-21 17:02:21]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-go/commit/4ab136ab49c856a5de394d15946eca3eb22143c0