scheduler: rename JobID to JobName to avoid overloading JobID meaning.

scheduler/appengine/engine/engine.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 // Package engine implements the core logic of the scheduler service.
 package engine
 
 import (
         "bytes"
         "encoding/json"
@@ skipping 239 matching lines @@
         Schedule string `gae:",noindex"`
 
         // Task is the job's payload in serialized form. Opaque from the point of view
         // of the engine. See Catalog.UnmarshalTask().
         Task []byte `gae:",noindex"`
 
         // State is the job's state machine state, see StateMachine.
         State JobState
 }
 
+func (e *Job) GetJobName() string {

[tandrii(chromium), 2017/06/21 16:16:07]

it seems you've meant to avoid public functions here, but it seems the logic of
splitting JobID really belongs to Job object itself.

+        // JobID has form <project>/<id>. Split it into components.
+        chunks := strings.Split(e.JobID, "/")
+        return chunks[1]
+}
+
 // effectiveSchedule returns schedule string to use for the job, considering its
 // Paused field.
 //
 // Paused jobs always use "triggered" schedule.
 func (e *Job) effectiveSchedule() string {
         if e.Paused {
                 return "triggered"
         }
         return e.Schedule
 }
@@ skipping 1660 matching lines @@
                 }
                 if hasFinished {
                         return ctl.eng.rollSM(c, job, func(sm *StateMachine) error {
                                 sm.OnInvocationDone(saving.ID)
                                 return nil
                         })
                 }
                 return nil
         })
 }