Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: scheduler/appengine/frontend/templates/includes/base.html

Issue 2948103002: scheduler: rename JobID to JobName to avoid overloading JobID meaning. (Closed)
Patch Set: more js lowercase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scheduler/appengine/engine/engine.go ('k') | scheduler/appengine/frontend/templates/pages/invocation.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scheduler/appengine/frontend/templates/includes/base.html
diff --git a/scheduler/appengine/frontend/templates/includes/base.html b/scheduler/appengine/frontend/templates/includes/base.html
index 144c012fab366694add951378951a85a0a92d22b..37735104683ee4aefde9166a749cec704e35ccf0 100644
--- a/scheduler/appengine/frontend/templates/includes/base.html
+++ b/scheduler/appengine/frontend/templates/includes/base.html
@@ -99,8 +99,8 @@ var xsrfToken = "{{.XsrfToken}}";
var postJobAction = function(btn, action) {
var form = $(btn).closest("form");
var projectID = $("input#projectID", form).val();
- var jobID = $("input#jobID", form).val();
- var url = "/actions/" + action + "/" + projectID + "/" + jobID;
+ var jobName = $("input#jobName", form).val();
+ var url = "/actions/" + action + "/" + projectID + "/" + jobName;
if (!form.attr("submitted")) {
$("input#xsrf_token", form).val(xsrfToken);
form.attr("action", url);
@@ -116,7 +116,7 @@ var postJobAction = function(btn, action) {
<form style="display: inline" method="POST">
<input type="hidden" id="xsrf_token" name="xsrf_token" value="">
<input type="hidden" id="projectID" value="{{.ProjectID}}">
- <input type="hidden" id="jobID" value="{{.JobID}}">
+ <input type="hidden" id="jobName" value="{{.JobName}}">
<div class="btn-group btn-group-xs" role="group">
{{if .Paused}}
<button type="button" class="btn btn-primary" onclick="postJobAction(this, 'resumeJob')">
@@ -145,9 +145,9 @@ var xsrfToken = "{{.XsrfToken}}";
var postInvocationAction = function(btn, action) {
var form = $(btn).closest("form");
var projectID = $("input#projectID", form).val();
- var jobID = $("input#jobID", form).val();
+ var jobName = $("input#jobName", form).val();
var invID = $("input#invID", form).val();
- var url = "/actions/" + action + "/" + projectID + "/" + jobID + "/" + invID;
+ var url = "/actions/" + action + "/" + projectID + "/" + jobName + "/" + invID;
if (!form.attr("submitted")) {
$("input#xsrf_token", form).val(xsrfToken);
form.attr("action", url);
@@ -163,7 +163,7 @@ var postInvocationAction = function(btn, action) {
<form style="display: inline" method="POST">
<input type="hidden" id="xsrf_token" name="xsrf_token" value="">
<input type="hidden" id="projectID" value="{{.ProjectID}}">
- <input type="hidden" id="jobID" value="{{.JobID}}">
+ <input type="hidden" id="jobName" value="{{.JobName}}">
<input type="hidden" id="invID" value="{{.InvID}}">
<div class="btn-group btn-group-xs" role="group">
<button type="button" class="btn btn-danger" onclick="postInvocationAction(this, 'abortInvocation')">
@@ -177,5 +177,5 @@ var postInvocationAction = function(btn, action) {
{{define "job-id-ref"}}
<span class="glyphicon {{.JobFlavorIcon}}" aria-hidden="true" title="{{.JobFlavorTitle}}">
</span>
-<a href="/jobs/{{.ProjectID}}/{{.JobID}}">{{.JobID}}</a>
+<a href="/jobs/{{.ProjectID}}/{{.JobName}}">{{.JobName}}</a>
{{end}}
« no previous file with comments | « scheduler/appengine/engine/engine.go ('k') | scheduler/appengine/frontend/templates/pages/invocation.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698