scheduler: rename JobID to JobName to avoid overloading JobID meaning.

scheduler/appengine/apiservers/scheduler_test.go

 // Copyright 2017 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package apiservers
 
 import (
         "testing"
 
         "golang.org/x/net/context"
@@ skipping 29 matching lines @@
                         fakeEng.getAllJobs = func() ([]*engine.Job, error) { return []*engine.Job{}, nil }
                         reply, err := ss.GetJobs(ctx, nil)
                         So(err, ShouldBeNil)
                         So(len(reply.GetJobs()), ShouldEqual, 0)
                 })
 
                 Convey("All Projects", func() {
                         fakeEng.getAllJobs = func() ([]*engine.Job, error) {
                                 return []*engine.Job{
                                         {
-                                                JobID:     "foo",
+                                                JobID:     "bar/foo",
                                                 ProjectID: "bar",
                                                 Schedule:  "0 * * * * * *",
                                                 State:     engine.JobState{State: engine.JobStateRunning},
                                                 Task:      taskBlob,
                                         },
                                         {
-                                                JobID:     "faz",
+                                                JobID:     "baz/faz",
                                                 Paused:    true,
                                                 ProjectID: "baz",
                                                 Schedule:  "with 1m interval",
                                                 State:     engine.JobState{State: engine.JobStateSuspended},
                                                 Task:      taskBlob,
                                         },
                                 }, nil
                         }
                         reply, err := ss.GetJobs(ctx, nil)
                         So(err, ShouldBeNil)
                         So(reply.GetJobs(), ShouldResemble, []*scheduler.Job{
                                 {
-                                        Id:       "foo",
+                                        Name:     "foo",
                                         Project:  "bar",
                                         Schedule: "0 * * * * * *",
                                         State:    &scheduler.JobState{UiStatus: "RUNNING"},
                                 },
                                 {
-                                        Id:       "faz",
+                                        Name:     "faz",
                                         Project:  "baz",
                                         Schedule: "with 1m interval",
                                         State:    &scheduler.JobState{UiStatus: "PAUSED"},
                                 },
                         })
                 })
 
                 Convey("One Project", func() {
                         fakeEng.getProjectJobs = func(projectID string) ([]*engine.Job, error) {
                                 So(projectID, ShouldEqual, "bar")
                                 return []*engine.Job{
                                         {
-                                                JobID:     "foo",
+                                                JobID:     "bar/foo",
                                                 ProjectID: "bar",
                                                 Schedule:  "0 * * * * * *",
                                                 State:     engine.JobState{State: engine.JobStateRunning},
                                                 Task:      taskBlob,
                                         },
                                 }, nil
                         }
                         reply, err := ss.GetJobs(ctx, &scheduler.JobsRequest{Project: "bar"})
                         So(err, ShouldBeNil)
                         So(reply.GetJobs(), ShouldResemble, []*scheduler.Job{
                                 {
-                                        Id:       "foo",
+                                        Name:     "foo",
                                         Project:  "bar",
                                         Schedule: "0 * * * * * *",
                                         State:    &scheduler.JobState{UiStatus: "RUNNING"},
                                 },
                         })
                 })
         })
 }
 
 ////
@@ skipping 68 matching lines @@
         panic("not implemented")
 }
 
 func (f *fakeEngine) AbortInvocation(c context.Context, jobID string, invID int64, who identity.Identity) error {
         panic("not implemented")
 }
 
 func (f *fakeEngine) AbortJob(c context.Context, jobID string, who identity.Identity) error {
         panic("not implemented")
 }