Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: scheduler/appengine/frontend/templates/pages/job.html

Issue 2948103002: scheduler: rename JobID to JobName to avoid overloading JobID meaning. (Closed)
Patch Set: more js lowercase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scheduler/appengine/frontend/templates/pages/job.html
diff --git a/scheduler/appengine/frontend/templates/pages/job.html b/scheduler/appengine/frontend/templates/pages/job.html
index 60e80ac67e3d8e4f5e5734147daf1bc056c600d3..af2d8abc08dae32012fa9842c6780d41c618ed0b 100644
--- a/scheduler/appengine/frontend/templates/pages/job.html
+++ b/scheduler/appengine/frontend/templates/pages/job.html
@@ -1,4 +1,4 @@
-{{define "title"}}LUCI Scheduler :: {{.Job.ProjectID}} :: {{.Job.JobID}}{{end}}
+{{define "title"}}LUCI Scheduler :: {{.Job.ProjectID}} :: {{.Job.JobName}}{{end}}
{{define "head"}}
<style type="text/css">
@@ -62,7 +62,7 @@
<tbody>
{{range .Invocations }}
<tr class="{{.RowClass}}">
- <td><a href="/jobs/{{$.Job.ProjectID}}/{{$.Job.JobID}}/{{.InvID}}">{{.InvID}}</a></td>
+ <td><a href="/jobs/{{$.Job.ProjectID}}/{{$.Job.JobName}}/{{.InvID}}">{{.InvID}}</a></td>
<td>{{.Started}}</td>
<td>{{.TriggeredBy}}</td>
<td>{{.Duration}}</td>
@@ -82,9 +82,9 @@
{{if .PrevCursor}}
<li class="previous">
{{if eq .PrevCursor "NULL"}}
- <a href="/jobs/{{$.Job.ProjectID}}/{{$.Job.JobID}}">
+ <a href="/jobs/{{$.Job.ProjectID}}/{{$.Job.JobName}}">
{{else}}
- <a href="/jobs/{{$.Job.ProjectID}}/{{$.Job.JobID}}?c={{.PrevCursor}}">
+ <a href="/jobs/{{$.Job.ProjectID}}/{{$.Job.JobName}}?c={{.PrevCursor}}">
{{end}}
<span aria-hidden="true">&larr;</span> Newer
</a>
@@ -96,7 +96,7 @@
{{end}}
{{if .NextCursor}}
<li class="next">
- <a href="/jobs/{{$.Job.ProjectID}}/{{$.Job.JobID}}?c={{.NextCursor}}">
+ <a href="/jobs/{{$.Job.ProjectID}}/{{$.Job.JobName}}?c={{.NextCursor}}">
Older <span aria-hidden="true">&rarr;</span>
</a>
</li>

Powered by Google App Engine
This is Rietveld 408576698