Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: scheduler/appengine/apiservers/scheduler_test.go

Issue 2948103002: scheduler: rename JobID to JobName to avoid overloading JobID meaning. (Closed)
Patch Set: more js lowercase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scheduler/appengine/apiservers/scheduler.go ('k') | scheduler/appengine/engine/engine.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scheduler/appengine/apiservers/scheduler_test.go
diff --git a/scheduler/appengine/apiservers/scheduler_test.go b/scheduler/appengine/apiservers/scheduler_test.go
index ba6ce8e467f8a050f5dba58c845ea7f90c46065b..66f85b4d5c536caf42e172a5a08426cff9e83945 100644
--- a/scheduler/appengine/apiservers/scheduler_test.go
+++ b/scheduler/appengine/apiservers/scheduler_test.go
@@ -47,14 +47,14 @@ func TestGetJobsApi(t *testing.T) {
fakeEng.getAllJobs = func() ([]*engine.Job, error) {
return []*engine.Job{
{
- JobID: "foo",
+ JobID: "bar/foo",
ProjectID: "bar",
Schedule: "0 * * * * * *",
State: engine.JobState{State: engine.JobStateRunning},
Task: taskBlob,
},
{
- JobID: "faz",
+ JobID: "baz/faz",
Paused: true,
ProjectID: "baz",
Schedule: "with 1m interval",
@@ -67,13 +67,13 @@ func TestGetJobsApi(t *testing.T) {
So(err, ShouldBeNil)
So(reply.GetJobs(), ShouldResemble, []*scheduler.Job{
{
- Id: "foo",
+ Name: "foo",
Project: "bar",
Schedule: "0 * * * * * *",
State: &scheduler.JobState{UiStatus: "RUNNING"},
},
{
- Id: "faz",
+ Name: "faz",
Project: "baz",
Schedule: "with 1m interval",
State: &scheduler.JobState{UiStatus: "PAUSED"},
@@ -86,7 +86,7 @@ func TestGetJobsApi(t *testing.T) {
So(projectID, ShouldEqual, "bar")
return []*engine.Job{
{
- JobID: "foo",
+ JobID: "bar/foo",
ProjectID: "bar",
Schedule: "0 * * * * * *",
State: engine.JobState{State: engine.JobStateRunning},
@@ -98,7 +98,7 @@ func TestGetJobsApi(t *testing.T) {
So(err, ShouldBeNil)
So(reply.GetJobs(), ShouldResemble, []*scheduler.Job{
{
- Id: "foo",
+ Name: "foo",
Project: "bar",
Schedule: "0 * * * * * *",
State: &scheduler.JobState{UiStatus: "RUNNING"},
« no previous file with comments | « scheduler/appengine/apiservers/scheduler.go ('k') | scheduler/appengine/engine/engine.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698