scheduler/appengine/apiservers/scheduler.go - Issue 2948103002: scheduler: rename JobID to JobName to avoid overloading JobID meaning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scheduler/appengine/apiservers/scheduler.go

Issue 2948103002: scheduler: rename JobID to JobName to avoid overloading JobID meaning. (Closed)

Patch Set: more js lowercase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scheduler/appengine/apiservers/scheduler.go

diff --git a/scheduler/appengine/apiservers/scheduler.go b/scheduler/appengine/apiservers/scheduler.go

index 02e1e9b0ce1224cc538a8f800abafca73de64c10..6cece118514558ea222f8dc80b621eb35cd63771 100644

--- a/scheduler/appengine/apiservers/scheduler.go

+++ b/scheduler/appengine/apiservers/scheduler.go

@@ -42,7 +42,7 @@ func (s SchedulerServer) GetJobs(ctx context.Context, in *scheduler.JobsRequest)

return nil, grpc.Errorf(codes.Internal, "failed to get traits: %s", err)

}

jobs[i] = &scheduler.Job{

- Id: ej.JobID,

+ Name: ej.GetJobName(),

Project: ej.ProjectID,

Schedule: ej.Schedule,

State: &scheduler.JobState{