[Devtools] Removed NetworkRequest dependency on NetworkManager

[Devtools] Removed NetworkRequest dependency on NetworkManager

This patch fully removes the dependency from NetworkRequest to
NetworkManager.

R=dgozman,pfeldman
BUG=374557
Review-Url: https://codereview.chromium.org/2921963002
Cr-Commit-Position: refs/heads/master@{#481044}
Committed: https://chromium.googlesource.com/chromium/src/+/88915910157839872025a8c20ec6d8d63678e3da

[allada, 2017-06-02 19:26:44]

Patchset #1 (id:1) has been deleted

[allada, 2017-06-02 19:26:50]

PTL

[allada, 2017-06-05 22:36:05]

PTaL - This removed NetworkManager from NetworkRequest and I removed the map of
NetworkManagers to NetworkRequests since it's only used in very rare cases.

[dgozman, 2017-06-06 20:54:41]

Let's deal with requestContent in this patch.

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
(right):

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js:430:
var manager = runtimeModel ? runtimeModel.target().model(SDK.NetworkManager) :
null;
nit: what was the point of renaming the variable?

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:64: static
managerForRequest(request) {
We usually do just forRequest or fromRequest.

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:84:
manager.target().networkAgent().replayXHR(request.requestId());
manager._networkAgent...

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:1022: //
TODO(allada) This should be moved into NetworkManager.
This should actually be abstracted away to work with HAR.

[allada, 2017-06-08 00:42:06]

> Let's deal with requestContent in this patch.
I'd prefer not to do requestContent in this patch as
it has nothing to do with this direct dependency. I
will have a follow up patch very soon.

PTaL

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
(right):

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js:430:
var manager = runtimeModel ? runtimeModel.target().model(SDK.NetworkManager) :
null;
On 2017/06/06 20:54:40, dgozman wrote:
> nit: what was the point of renaming the variable?

It was just so I could fit the line below on one line.

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:64: static
managerForRequest(request) {
On 2017/06/06 20:54:40, dgozman wrote:
> We usually do just forRequest or fromRequest.

Done.

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:84:
manager.target().networkAgent().replayXHR(request.requestId());
On 2017/06/06 20:54:41, dgozman wrote:
> manager._networkAgent...

Done.

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/2921963002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:1022: //
TODO(allada) This should be moved into NetworkManager.
On 2017/06/06 20:54:41, dgozman wrote:
> This should actually be abstracted away to work with HAR.

Well HAR import will set the content of the request while it's
generating them, and then it'll try to look it up from networkmanager
assuming it exists for the request.

[dgozman, 2017-06-08 18:12:46]

On 2017/06/08 00:42:06, allada wrote:
> > Let's deal with requestContent in this patch.
> I'd prefer not to do requestContent in this patch as
> it has nothing to do with this direct dependency. I
> will have a follow up patch very soon.
Ok. lgtm

[allada, 2017-06-08 22:44:09]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 22:44:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 01:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 01:08:08]

Dry run: This issue passed the CQ dry run.

[allada, 2017-06-20 21:48:54]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 21:49:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2017-06-20 23:23:34]

The CQ bit was unchecked by allada@chromium.org

[allada, 2017-06-20 23:23:40]

The CQ bit was checked by allada@chromium.org

[allada, 2017-06-20 23:23:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2921963002/#ps120001
(title: "Merge branch 'REMOVE_REDIRECTS_REBASE' into REMOVE_MANAGER_DEPENDENCY")

[commit-bot: I haz the power, 2017-06-20 23:23:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 00:33:08]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1498001020841450,
"parent_rev": "3df4c7446b9f3421636917277428f71a306a857f", "commit_rev":
"88915910157839872025a8c20ec6d8d63678e3da"}

[commit-bot: I haz the power, 2017-06-21 00:33:25]

Description was changed from

==========
[Devtools] Removed NetworkRequest dependency on NetworkManager

This patch fully removes the dependency from NetworkRequest to
NetworkManager.

R=dgozman,pfeldman
BUG=374557
==========

to

==========
[Devtools] Removed NetworkRequest dependency on NetworkManager

This patch fully removes the dependency from NetworkRequest to
NetworkManager.

R=dgozman,pfeldman
BUG=374557

Review-Url: https://codereview.chromium.org/2921963002
Cr-Commit-Position: refs/heads/master@{#481044}
Committed:
https://chromium.googlesource.com/chromium/src/+/88915910157839872025a8c20ec6...
==========

[commit-bot: I haz the power, 2017-06-21 00:33:27]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/88915910157839872025a8c20ec6...