third_party/WebKit/LayoutTests/inspector/network/network-toggle-type-filter.html - Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/network/network-toggle-type-filter.html

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)

Patch Set: Merge branch 'REMOVE_REDIRECTS_REBASE' into REMOVE_MANAGER_DEPENDENCY Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html ('k') | third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/network/network-toggle-type-filter.html

diff --git a/third_party/WebKit/LayoutTests/inspector/network/network-toggle-type-filter.html b/third_party/WebKit/LayoutTests/inspector/network/network-toggle-type-filter.html

index 927aaa34079e2d4e5bdf415d88b3a437a0ce5d75..854d7687ed8b3f4bd714dcc3bcfce6406dce2a7c 100644

--- a/third_party/WebKit/LayoutTests/inspector/network/network-toggle-type-filter.html

+++ b/third_party/WebKit/LayoutTests/inspector/network/network-toggle-type-filter.html

@@ -14,7 +14,7 @@ function test() {

InspectorTest.addResult((toggle ? "Toggled '" : "Clicked '") + buttonName + "' button.");

target._resourceCategoryFilterUI._toggleTypeFilter(buttonName, toggle);

var results = [];

- var request = new SDK.NetworkRequest(SDK.targetManager.mainTarget(), "", "", "", "", "");

+ var request = new SDK.NetworkRequest("", "", "", "", "");

for (var typeId in types) {

var type = Common.resourceTypes[typeId];

results.push(type.name() + ": " + target._resourceCategoryFilterUI.accept(type.category().title));