third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html - Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)

Patch Set: Merge branch 'REMOVE_REDIRECTS_REBASE' into REMOVE_MANAGER_DEPENDENCY Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/waterfall-images.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-headers.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

index b2eadbcbd4989eda5301f5af5472c70b1df08056..0cdad8dc7277950d4b23aaab18dc268dba428fb1 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

@@ -18,7 +18,7 @@ function test()

function responseReceived(requestId, time, resourceType, response)

{

- var request = InspectorTest.networkLog.requestForId(InspectorTest.networkManager, requestId);

+ var request = InspectorTest.networkLog.requestByManagerAndId(InspectorTest.networkManager, requestId);

if (/x-frame-options-deny\.cgi/.exec(request.url())) {

InspectorTest.addResult("Received response for x-frame-options-deny.cgi");

InspectorTest.addResult("SUCCESS");

@@ -28,14 +28,14 @@ function test()

function loadingFinished(requestId, finishTime)

{

- var request = InspectorTest.networkLog.requestForId(InspectorTest.networkManager, requestId);

+ var request = InspectorTest.networkLog.requestByManagerAndId(InspectorTest.networkManager, requestId);

if (/x-frame-options-deny\.cgi/.exec(request.url()))

InspectorTest.completeTest();

}

function loadingFailed(requestId, time, localizedDescription, canceled)

{

- var request = InspectorTest.networkLog.requestForId(InspectorTest.networkManager, requestId);

+ var request = InspectorTest.networkLog.requestByManagerAndId(InspectorTest.networkManager, requestId);

if (/x-frame-options-deny\.cgi/.exec(request.url())) {

InspectorTest.addResult("TODO(mkwst): This started failing when we moved XFO to the browser.");

InspectorTest.completeTest();