third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html - Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)

Patch Set: Merge branch 'REMOVE_REDIRECTS_REBASE' into REMOVE_MANAGER_DEPENDENCY Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/failed-request.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/security/main-origin-assigned-despite-request-missing.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html

index fa121cb01bb44256f9f2886079c92a42f3af1fbc..99a1212b24b39e716085b2c39f5d523e44fed03a 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html

@@ -6,11 +6,11 @@

function test()

{

- var request1 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://foo.test/", "https://foo.test", 0, 0, null);

+ var request1 = new SDK.NetworkRequest(0, "https://foo.test/", "https://foo.test", 0, 0, null);

request1.setSecurityState(Protocol.Security.SecurityState.Secure);

InspectorTest.dispatchRequestFinished(request1);

- var request2 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://bar.test/foo.jpg", "https://bar.test", 0, 0, null);

+ var request2 = new SDK.NetworkRequest(0, "https://bar.test/foo.jpg", "https://bar.test", 0, 0, null);

request2.setSecurityState(Protocol.Security.SecurityState.Secure);

InspectorTest.dispatchRequestFinished(request2);

@@ -20,7 +20,7 @@ function test()

// Test that the sidebar is hidden when an interstitial is shown. https://crbug.com/559150

InspectorTest.mainTarget.model(SDK.ResourceTreeModel).dispatchEventToListeners(SDK.ResourceTreeModel.Events.InterstitialShown);

// Simulate a request finishing after the interstitial is shown, to make sure that doesn't show up in the sidebar.

- var request3 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://bar.test/foo.jpg", "https://bar.test", 0, 0, null);

+ var request3 = new SDK.NetworkRequest(0, "https://bar.test/foo.jpg", "https://bar.test", 0, 0, null);

request3.setSecurityState(Protocol.Security.SecurityState.Unknown);

InspectorTest.dispatchRequestFinished(request3);

InspectorTest.addResult("After interstitial is shown:");