Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)
Patch Set: Merge branch 'REMOVE_REDIRECTS_REBASE' into REMOVE_MANAGER_DEPENDENCY Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index a61940cafb457bb6005c79155c83741513151336..cc6679d66e7c33d7fa28c2dc9cd095db309b236c 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -854,7 +854,9 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
this._nameBadgeElement.classList.add('network-badge');
}
cell.appendChild(this._nameBadgeElement);
- cell.createTextChild(this._request.networkManager().target().decorateLabel(this._request.name().trimMiddle(100)));
+ var name = this._request.name().trimMiddle(100);
+ var networkManager = SDK.NetworkManager.forRequest(this._request);
+ cell.createTextChild(networkManager ? networkManager.target().decorateLabel(name) : name);
this._appendSubtitle(cell, this._request.path());
cell.title = this._request.url();
}
@@ -946,8 +948,9 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
break;
case SDK.NetworkRequest.InitiatorType.Script:
+ var networkManager = SDK.NetworkManager.forRequest(request);
this._linkifiedInitiatorAnchor = this.parentView().linkifier.linkifyScriptLocation(
- request.networkManager().target(), initiator.scriptId, initiator.url, initiator.lineNumber,
+ networkManager ? networkManager.target() : null, initiator.scriptId, initiator.url, initiator.lineNumber,
initiator.columnNumber);
this._linkifiedInitiatorAnchor.title = '';
cell.appendChild(this._linkifiedInitiatorAnchor);

Powered by Google App Engine
This is Rietveld 408576698