third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js - Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)

Patch Set: Merge branch 'REMOVE_REDIRECTS_REBASE' into REMOVE_MANAGER_DEPENDENCY Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

index 9e3cef25b811bf396fb72a3a23b7294252d59fd5..ba5937a821b38932bbd07de0b2505c768fddae06 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

@@ -542,8 +542,9 @@ Network.NetworkLogViewColumns = class {

return {

box: anchor.boxInWindow(),

show: popover => {

+ var manager = anchor.request ? SDK.NetworkManager.forRequest(anchor.request) : null;

var content = Components.DOMPresentationUtils.buildStackTracePreviewContents(

- anchor.request.networkManager().target(), this._popupLinkifier, initiator.stack);

+ manager ? manager.target() : null, this._popupLinkifier, initiator.stack);

popover.contentElement.appendChild(content);

return Promise.resolve(true);