Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2921053002: [Devtools] Removed "redirects" from NetworkRequest to use redirectSource (Closed)

Created:
3 years, 6 months ago by allada
Modified:
3 years, 6 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Removed "redirects" from NetworkRequest to use redirectSource redirectSource was always a chain that linked to the previous redirect and could walk the chain from request to request. NetworkManager was setting "redirects" on the request and it was used in a few parts of the code but NetworkRequest never exposed it for use. Since redirects is not needed except when appending a new redirect to the chain I removed it and walked the chain instead for those cases. R=dgozman,pfeldman BUG=None Review-Url: https://codereview.chromium.org/2921053002 Cr-Commit-Position: refs/heads/master@{#480984} Committed: https://chromium.googlesource.com/chromium/src/+/a2ba03c01719f869438d7129cbeebe07f14fef03

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Merge branch 'MOVE_NETWORK_STUFF_AROUND' into REMOVE_REDIRECTS_REBASE #

Patch Set 4 : Merge branch 'MOVE_NETWORK_STUFF_AROUND' into REMOVE_REDIRECTS_REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js View 1 2 3 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
allada
PTL
3 years, 6 months ago (2017-06-02 18:06:10 UTC) #1
dgozman
Don't you have to change any tests? lgtm
3 years, 6 months ago (2017-06-02 22:06:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921053002/60001
3 years, 6 months ago (2017-06-20 18:44:46 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 22:12:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a2ba03c01719f869438d7129cbee...

Powered by Google App Engine
This is Rietveld 408576698