Fill is_chrome_signin_password field in the password entry pings.

Fill is_chrome_signin_password field in the password entry pings.

For all the password reuse triggered by CheckSyncPasswordReuse(..),
set the saved_domain to password_manager::kSyncPasswordDomain to
distinguish from saved password reuse.
Related BUILD files are adjusted. And this CL also moves the creation
and removal of PasswordProtectionService instances to SB service delegate.

BUG=698899
Review-Url: https://codereview.chromium.org/2912383004
Cr-Commit-Position: refs/heads/master@{#477816}
Committed: https://chromium.googlesource.com/chromium/src/+/4cd85bfda2021baba6a044d565323ab88e598398

[Jialiu Lin, 2017-05-31 21:17:42]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 21:18:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-05-31 21:58:18]

jialiul@chromium.org changed reviewers:
+ dvadym@chromium.org, nparker@chromium.org

[Jialiu Lin, 2017-05-31 21:58:18]

Hi dvadym@,
I filled the is_chrome_signin_password field based on the domain of the saved
password. Let me know if this change makes sense to you. 

Thanks,

[Nathan Parker, 2017-05-31 22:40:54]

nparker@chromium.org changed reviewers:
+ vakh@chromium.org

[Nathan Parker, 2017-05-31 22:40:55]

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
File components/safe_browsing/password_protection/DEPS (left):

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
components/safe_browsing/password_protection/DEPS:6:
"+components/safe_browsing_db",
how is this not needed? Or is it included from the directory above?

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
File components/safe_browsing/password_protection/password_protection_request.cc
(right):

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
components/safe_browsing/password_protection/password_protection_request.cc:133:
reuse_event->set_is_chrome_signin_password(
I think we want to know that this password matches the chrome-sync password,
rather than the URL matches google.  Otherwise, someone could save their google
password (but not sync with it) and we'd end up marking this true.

[vakh (use Gerrit instead), 2017-06-01 00:02:25]

lgtm modulo nparker's comment in .cc file

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
File components/safe_browsing/password_protection/DEPS (left):

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
components/safe_browsing/password_protection/DEPS:6:
"+components/safe_browsing_db",
On 2017/05/31 22:40:55, Nathan Parker wrote:
> how is this not needed? Or is it included from the directory above?

Yes, but I appreciate the RED color :)

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
File
components/safe_browsing/password_protection/password_protection_service_unittest.cc
(right):

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
components/safe_browsing/password_protection/password_protection_service_unittest.cc:652:
EXPECT_TRUE(
I think this should be an ASSERT

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
components/safe_browsing/password_protection/password_protection_service_unittest.cc:659:
net::TestURLFetcher fetcher(0, GURL("http://bar.com"), nullptr);
There's plenty of overlap in these tests. Do you think it would be useful to
write a common function that does the common things?

[Jialiu Lin, 2017-06-01 00:30:34]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 00:31:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 00:40:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 00:40:55]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Jialiu Lin, 2017-06-01 00:44:03]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 00:44:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-06-01 00:45:46]

Patchset #4 (id:60001) has been deleted

[Jialiu Lin, 2017-06-01 00:45:54]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 00:46:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 00:51:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 00:51:27]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Jialiu Lin, 2017-06-01 01:07:58]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[Jialiu Lin, 2017-06-01 01:08:12]

Patchset #4 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-06-01 01:08:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 01:16:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 01:16:23]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Jialiu Lin, 2017-06-01 01:22:01]

Seems ios bots are not happy with my change. I'm still working on fixing
dependencies.

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
File components/safe_browsing/password_protection/DEPS (left):

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
components/safe_browsing/password_protection/DEPS:6:
"+components/safe_browsing_db",
On 2017/05/31 22:40:55, Nathan Parker wrote:
> how is this not needed? Or is it included from the directory above?

Yes, these are already included in the components/safe_browsing/DEPS

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
components/safe_browsing/password_protection/DEPS:6:
"+components/safe_browsing_db",
On 2017/06/01 00:02:25, vakh (Varun Khaneja) wrote:
> On 2017/05/31 22:40:55, Nathan Parker wrote:
> > how is this not needed? Or is it included from the directory above?
> 
> Yes, but I appreciate the RED color :)

Acknowledged.

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
File components/safe_browsing/password_protection/password_protection_request.cc
(right):

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
components/safe_browsing/password_protection/password_protection_request.cc:133:
reuse_event->set_is_chrome_signin_password(
On 2017/05/31 22:40:55, Nathan Parker wrote:
> I think we want to know that this password matches the chrome-sync password,
> rather than the URL matches google.  Otherwise, someone could save their
google
> password (but not sync with it) and we'd end up marking this true.

You're right. I overlooked this possibility.
My latest patch uses a semi-hacky way to distinguish chrome sync
password reuse without changing too much password_manager code.

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
File
components/safe_browsing/password_protection/password_protection_service_unittest.cc
(right):

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
components/safe_browsing/password_protection/password_protection_service_unittest.cc:652:
EXPECT_TRUE(
On 2017/06/01 00:02:25, vakh (Varun Khaneja) wrote:
> I think this should be an ASSERT

Done.

https://codereview.chromium.org/2912383004/diff/20001/components/safe_browsin...
components/safe_browsing/password_protection/password_protection_service_unittest.cc:659:
net::TestURLFetcher fetcher(0, GURL("http://bar.com"), nullptr);
On 2017/06/01 00:02:25, vakh (Varun Khaneja) wrote:
> There's plenty of overlap in these tests. Do you think it would be useful to
> write a common function that does the common things?

I'll combine these two tests, such that they can share common setup code.

[Jialiu Lin, 2017-06-01 02:38:13]

Hi dvadym@ and nparker@, 
Could you hold your review for a moment? There are still a couple of things need
fixing. I'll ping you again once this CL is ready for review. 

Thanks

[Jialiu Lin, 2017-06-01 20:29:58]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 20:30:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-06-01 21:11:47]

Description was changed from

==========
Fill is_chrome_signin_password field in the password entry pings.

BUG=698899
==========

to

==========
Fill is_chrome_signin_password field in the password entry pings.

For all the password reuse triggered by CheckSyncPasswordReuse(..),
set the saved_domain to safe_browsing::kSyncPasswordDomain to
distinguish from saved password reuse. 

BUG=698899
==========

[Jialiu Lin, 2017-06-01 23:56:28]

Hi dvadym@, 
Since we are not using the |saved_domain| so far, I added a constant to help
distinguish sync password reuse and saved password reuse. Let me know if this
approach makes sense.

[commit-bot: I haz the power, 2017-06-02 00:17:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 00:17:34]

Dry run: This issue passed the CQ dry run.

[dvadym, 2017-06-02 09:28:55]

Hi Jialiu, 
 yeah, this approach makes sense. See my comment below

https://codereview.chromium.org/2912383004/diff/110001/components/password_ma...
File components/password_manager/core/browser/password_reuse_detector_consumer.h
(right):

https://codereview.chromium.org/2912383004/diff/110001/components/password_ma...
components/password_manager/core/browser/password_reuse_detector_consumer.h:25:
// safe_browsing::kChromeSyncDomain if |password| is a sync password.
Would it be possible to move kChromeSyncDomain to PasswordManager code, for
example to this file? It looks like kChromeSyncDomain is part of PasswordReuse
API so it's more logical to have it inside Reuse detection code. So if we decide
to use Password Reuse detection in our code, it will be not needed to add
SafeBrowsing dependencies.

[Jialiu Lin, 2017-06-03 00:08:58]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-03 00:09:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-06-03 00:12:31]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-03 00:12:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 00:40:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 00:40:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jialiu Lin, 2017-06-05 16:52:59]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 16:53:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 17:39:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 17:39:17]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Jialiu Lin, 2017-06-05 17:54:14]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 17:54:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 18:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 18:33:27]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Jialiu Lin, 2017-06-05 20:00:15]

Description was changed from

==========
Fill is_chrome_signin_password field in the password entry pings.

For all the password reuse triggered by CheckSyncPasswordReuse(..),
set the saved_domain to safe_browsing::kSyncPasswordDomain to
distinguish from saved password reuse. 

BUG=698899
==========

to

==========
Fill is_chrome_signin_password field in the password entry pings.

For all the password reuse triggered by CheckSyncPasswordReuse(..),
set the saved_domain to password_manager::kSyncPasswordDomain to
distinguish from saved password reuse. Related BUILD files are adjusted.

BUG=698899
==========

[Jialiu Lin, 2017-06-05 20:00:54]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[Jialiu Lin, 2017-06-05 20:00:57]

Patchset #9 (id:190001) has been deleted

[commit-bot: I haz the power, 2017-06-05 20:01:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 20:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 20:44:32]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Jialiu Lin, 2017-06-05 22:14:42]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 22:15:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 22:45:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 22:45:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jialiu Lin, 2017-06-05 23:24:40]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 23:25:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-06-06 00:17:31]

Description was changed from

==========
Fill is_chrome_signin_password field in the password entry pings.

For all the password reuse triggered by CheckSyncPasswordReuse(..),
set the saved_domain to password_manager::kSyncPasswordDomain to
distinguish from saved password reuse. Related BUILD files are adjusted.

BUG=698899
==========

to

==========
Fill is_chrome_signin_password field in the password entry pings.

For all the password reuse triggered by CheckSyncPasswordReuse(..),
set the saved_domain to password_manager::kSyncPasswordDomain to
distinguish from saved password reuse.
Related BUILD files are adjusted. And this CL also moves the creation
and removal of PasswordProtectionService instances to SB service delegate.

BUG=698899
==========

[Jialiu Lin, 2017-06-06 01:00:53]

Thanks dvadym@! I've moved the new constant to password_manager namespace.

https://codereview.chromium.org/2912383004/diff/110001/components/password_ma...
File components/password_manager/core/browser/password_reuse_detector_consumer.h
(right):

https://codereview.chromium.org/2912383004/diff/110001/components/password_ma...
components/password_manager/core/browser/password_reuse_detector_consumer.h:25:
// safe_browsing::kChromeSyncDomain if |password| is a sync password.
On 2017/06/02 09:28:55, dvadym (OOO till June 6) wrote:
> Would it be possible to move kChromeSyncDomain to PasswordManager code, for
> example to this file? It looks like kChromeSyncDomain is part of PasswordReuse
> API so it's more logical to have it inside Reuse detection code. So if we
decide
> to use Password Reuse detection in our code, it will be not needed to add
> SafeBrowsing dependencies.

Done.
I thought I would encounter some circular dependencies. It turns out
PasswordReuseDetectionManager no longer needs to depends on
PasswordProtectionService. Constant moved to password_manager namespace.

[commit-bot: I haz the power, 2017-06-06 03:34:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 03:34:22]

Dry run: This issue passed the CQ dry run.

[dvadym, 2017-06-06 09:10:19]

LGTM

https://codereview.chromium.org/2912383004/diff/110001/components/password_ma...
File components/password_manager/core/browser/password_reuse_detector_consumer.h
(right):

https://codereview.chromium.org/2912383004/diff/110001/components/password_ma...
components/password_manager/core/browser/password_reuse_detector_consumer.h:25:
// safe_browsing::kChromeSyncDomain if |password| is a sync password.
On 2017/06/06 01:00:53, Jialiu Lin wrote:
> On 2017/06/02 09:28:55, dvadym (OOO till June 6) wrote:
> > Would it be possible to move kChromeSyncDomain to PasswordManager code, for
> > example to this file? It looks like kChromeSyncDomain is part of
PasswordReuse
> > API so it's more logical to have it inside Reuse detection code. So if we
> decide
> > to use Password Reuse detection in our code, it will be not needed to add
> > SafeBrowsing dependencies.
> 
> Done.
> I thought I would encounter some circular dependencies. It turns out
> PasswordReuseDetectionManager no longer needs to depends on
> PasswordProtectionService. Constant moved to password_manager namespace. 

Great, thanks for moving it.

[Jialiu Lin, 2017-06-06 16:23:47]

Thank you dvadym@! 

nparker@, vakh@, could you review for safe_browsing side of change?  Thanks!

[Jialiu Lin, 2017-06-07 21:15:14]

ping nparker@ and vakh@

vakh@, I made some updates after your LGTM, let me know if it still looks good
to you.

[Nathan Parker, 2017-06-07 22:16:06]

lgtm

https://codereview.chromium.org/2912383004/diff/250001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/services_delegate_stub.cc (right):

https://codereview.chromium.org/2912383004/diff/250001/chrome/browser/safe_br...
chrome/browser/safe_browsing/services_delegate_stub.cc:78: return nullptr;
nit: Does this get called?  If not, you could NOTIMPLEMENTED() here to ensure it
stays that way.

https://codereview.chromium.org/2912383004/diff/250001/components/password_ma...
File components/password_manager/core/browser/password_reuse_detector.cc
(right):

https://codereview.chromium.org/2912383004/diff/250001/components/password_ma...
components/password_manager/core/browser/password_reuse_detector.cc:40: const
char kSyncPasswordDomain[] = "chrome_sync";
nit: how about making this not a valid hostname ("CHROME SYNC"?) to ensure no
one ever has a real domain w/ this same name?

[Jialiu Lin, 2017-06-07 22:41:21]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 22:41:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-06-07 22:41:50]

Thanks nparker@! Your comments are addressed.

https://codereview.chromium.org/2912383004/diff/250001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/services_delegate_stub.cc (right):

https://codereview.chromium.org/2912383004/diff/250001/chrome/browser/safe_br...
chrome/browser/safe_browsing/services_delegate_stub.cc:78: return nullptr;
On 2017/06/07 22:16:06, Nathan Parker wrote:
> nit: Does this get called?  If not, you could NOTIMPLEMENTED() here to ensure
it
> stays that way.

NOTIMPLEMENTED() added.

https://codereview.chromium.org/2912383004/diff/250001/components/password_ma...
File components/password_manager/core/browser/password_reuse_detector.cc
(right):

https://codereview.chromium.org/2912383004/diff/250001/components/password_ma...
components/password_manager/core/browser/password_reuse_detector.cc:40: const
char kSyncPasswordDomain[] = "chrome_sync";
On 2017/06/07 22:16:06, Nathan Parker wrote:
> nit: how about making this not a valid hostname ("CHROME SYNC"?) to ensure no
> one ever has a real domain w/ this same name?  

Done.

[Jialiu Lin, 2017-06-07 23:50:34]

The CQ bit was unchecked by jialiul@chromium.org

[Jialiu Lin, 2017-06-07 23:50:41]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2017-06-07 23:50:42]

The patchset sent to the CQ was uploaded after l-g-t-m from vakh@chromium.org,
nparker@chromium.org, dvadym@chromium.org
Link to the patchset: https://codereview.chromium.org/2912383004/#ps270001
(title: "address nparker's comments")

[commit-bot: I haz the power, 2017-06-07 23:51:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 00:09:48]

CQ is committing da patch.

Bot data: {"patchset_id": 270001, "attempt_start_ts": 1496879441881920,
"parent_rev": "95f00bd53528fee18ef3ccaa08690c6a1996045d", "commit_rev":
"4cd85bfda2021baba6a044d565323ab88e598398"}

[commit-bot: I haz the power, 2017-06-08 00:09:59]

Description was changed from

==========
Fill is_chrome_signin_password field in the password entry pings.

For all the password reuse triggered by CheckSyncPasswordReuse(..),
set the saved_domain to password_manager::kSyncPasswordDomain to
distinguish from saved password reuse.
Related BUILD files are adjusted. And this CL also moves the creation
and removal of PasswordProtectionService instances to SB service delegate.

BUG=698899
==========

to

==========
Fill is_chrome_signin_password field in the password entry pings.

For all the password reuse triggered by CheckSyncPasswordReuse(..),
set the saved_domain to password_manager::kSyncPasswordDomain to
distinguish from saved password reuse.
Related BUILD files are adjusted. And this CL also moves the creation
and removal of PasswordProtectionService instances to SB service delegate.

BUG=698899

Review-Url: https://codereview.chromium.org/2912383004
Cr-Commit-Position: refs/heads/master@{#477816}
Committed:
https://chromium.googlesource.com/chromium/src/+/4cd85bfda2021baba6a044d56532...
==========

[commit-bot: I haz the power, 2017-06-08 00:10:00]

Committed patchset #12 (id:270001) as
https://chromium.googlesource.com/chromium/src/+/4cd85bfda2021baba6a044d56532...