components/password_manager/core/browser/password_reuse_detection_manager.cc - Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_reuse_detection_manager.cc

Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings. (Closed)

Patch Set: address nparker's comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/DEPS ('k') | components/password_manager/core/browser/password_reuse_detector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_reuse_detection_manager.cc

diff --git a/components/password_manager/core/browser/password_reuse_detection_manager.cc b/components/password_manager/core/browser/password_reuse_detection_manager.cc

index d4942acfa58cb15032005520d31f21c588b5a51b..49a0691399e0a7c90b1a21ea00a0efc839df3917 100644

--- a/components/password_manager/core/browser/password_reuse_detection_manager.cc

+++ b/components/password_manager/core/browser/password_reuse_detection_manager.cc

@@ -11,9 +11,6 @@

#include "components/password_manager/core/browser/password_manager_metrics_util.h"

#include "components/password_manager/core/browser/password_manager_util.h"

#include "ui/events/keycodes/keyboard_codes_posix.h"

-#if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)

-#include "components/safe_browsing/password_protection/password_protection_service.h"

-#endif

using base::Time;

using base::TimeDelta;