components/safe_browsing/password_protection/DEPS - Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/safe_browsing/password_protection/DEPS

Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings. (Closed)

Patch Set: clean up DEPS file Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | components/safe_browsing/password_protection/password_protection_request.cc » ('j') | components/safe_browsing/password_protection/password_protection_request.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "-content",

3 "+components/content_settings/core/browser",	2 "+components/content_settings/core/browser",

4 "+components/history/core/browser",	3 "+components/history/core/browser",

5 "+components/safe_browsing/csd.pb.h",

6 "+components/safe_browsing_db",
Nathan Parker 2017/05/31 22:40:55 how is this not needed? Or is it included from the how is this not needed? Or is it included from the directory above? vakh (use Gerrit instead) 2017/06/01 00:02:25 Yes, but I appreciate the RED color :) Show quoted text On 2017/05/31 22:40:55, Nathan Parker wrote: > how is this not needed? Or is it included from the directory above? Yes, but I appreciate the RED color :) Jialiu Lin 2017/06/01 01:22:01 Acknowledged. Show quoted text On 2017/06/01 00:02:25, vakh (Varun Khaneja) wrote: > On 2017/05/31 22:40:55, Nathan Parker wrote: > > how is this not needed? Or is it included from the directory above? > > Yes, but I appreciate the RED color :) Acknowledged. Jialiu Lin 2017/06/01 01:22:01 Yes, these are already included in the components/ Show quoted text On 2017/05/31 22:40:55, Nathan Parker wrote: > how is this not needed? Or is it included from the directory above? Yes, these are already included in the components/safe_browsing/DEPS
7 "+components/sync_preferences/testing_pref_service_syncable.h",	4 "+components/sync_preferences/testing_pref_service_syncable.h",

8 "+content/public/browser",

9 "+content/public/test",	5 "+content/public/test",

10 "+net",

11 ]	6 ]

12	7

OLD	NEW