Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings. (Closed)
Patch Set: address nparker's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store_unittest.cc
diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc
index c32f2e14791ab838e6d82caad290e1b2571b99ff..7f166a813a525a194957508582c13b386b20ffdf 100644
--- a/components/password_manager/core/browser/password_store_unittest.cc
+++ b/components/password_manager/core/browser/password_store_unittest.cc
@@ -28,6 +28,7 @@
#include "components/password_manager/core/browser/affiliation_service.h"
#include "components/password_manager/core/browser/mock_affiliated_match_helper.h"
#include "components/password_manager/core/browser/password_manager_test_utils.h"
+#include "components/password_manager/core/browser/password_reuse_detector.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
#include "components/password_manager/core/browser/password_store_default.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -989,8 +990,9 @@ TEST_F(PasswordStoreTest, SavingClearingSyncPassword) {
// Check that sync password reuse is found.
MockPasswordReuseDetectorConsumer mock_consumer;
- EXPECT_CALL(mock_consumer,
- OnReuseFound(sync_password, "accounts.google.com", 1, 0));
+ EXPECT_CALL(
+ mock_consumer,
+ OnReuseFound(sync_password, std::string(kSyncPasswordDomain), 1, 0));
store->CheckReuse(input, "https://facebook.com", &mock_consumer);
base::RunLoop().RunUntilIdle();
testing::Mock::VerifyAndClearExpectations(&mock_consumer);

Powered by Google App Engine
This is Rietveld 408576698