components/password_manager/core/browser/password_reuse_detector_consumer.h - Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_reuse_detector_consumer.h

Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings. (Closed)

Patch Set: address nparker's comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_reuse_detector.cc ('k') | components/password_manager/core/browser/password_reuse_detector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_reuse_detector_consumer.h

diff --git a/components/password_manager/core/browser/password_reuse_detector_consumer.h b/components/password_manager/core/browser/password_reuse_detector_consumer.h

index b621b777e4fa024255dded6d761721c11b1a6d6c..fb6dc8c817aea22cf472e3199515816c8beac662 100644

--- a/components/password_manager/core/browser/password_reuse_detector_consumer.h

+++ b/components/password_manager/core/browser/password_reuse_detector_consumer.h

@@ -21,8 +21,8 @@ class PasswordReuseDetectorConsumer

virtual ~PasswordReuseDetectorConsumer();

// Called when a password reuse is found.

- // |legitimate_domain| is the domain on which |password| is saved or the sync

- // domain if |password| is a sync password.

+ // |legitimate_domain| is the domain on which |password| is saved or

+ // safe_browsing::kChromeSyncDomain if |password| is a sync password.

// |saved_passwords| is total number of passwords stored in Password Manager.

// |number_matches| is a number of sites on which |password| is saved.

virtual void OnReuseFound(const base::string16& password,